public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: uweigand@de.ibm.com
Subject: [PATCH 0/4] Allow larger sizes for tracepoint register masks
Date: Wed, 20 Jun 2018 21:09:00 -0000	[thread overview]
Message-ID: <20180620210855.6385-1-pedromfc@linux.vnet.ibm.com> (raw)

Currently, the size of the register mask for tracepoint action packets
is limited to 32 bytes, due to the size of an internal array. This
patch series changes the array to a vector so that it can be sized
according to the number of registers in the arch.

The motivation for this is that I'm working on enabling additional
registers for powerpc, and there are more registers that can be
represented with the current mask size, so actions like "collect
$regs" don't work.

The series also changes the remote target to use the remote packet
size when sending tracepoint packets, because with larger masks it no
longer can be assumed that the mask will fit in a packet.

Patches 1-2 fix minor issues in remote_target::download_tracepoint, so
that patch 3 can change the method to use the remote packet
size. Patch 1 fixes an indentation error, and patch 2 fixes an error
that caused the last QTDP action packet to include the '-' trailing
indicator for additional action packets.

Patch 3 uses the remote packet size for the buffer used to build the
QTDP packets and changes all writes to this buffer to xsnprintf.

Patch 4 changes collection_list to build a variable-sized register
mask.

I also noticed that collection_list sometimes uses local register
numbers, and sometimes remote register numbers to set the bits in the
register mask, and allows pseudoregister numbers to be set in the
mask, but his issue isn't fixed in this series.

Pedro Franco de Carvalho (4):
  Fix indentation in remote_target::download_tracepoint
  Remove trailing '-' from the last QTDP action packet
  Use get_remote_packet_size in download_tracepoint
  Variable size for regs mask in collection list

 gdb/remote.c     | 102 ++++++++++++++++++++++++++++++++-----------------------
 gdb/tracepoint.c |  28 +++++++++++----
 gdb/tracepoint.h |   2 +-
 3 files changed, 82 insertions(+), 50 deletions(-)

-- 
2.13.6

             reply	other threads:[~2018-06-20 21:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 21:09 Pedro Franco de Carvalho [this message]
2018-06-20 21:09 ` [PATCH 3/4] Use get_remote_packet_size in download_tracepoint Pedro Franco de Carvalho
2018-06-25 10:37   ` Ulrich Weigand
2018-06-25 20:51     ` Pedro Franco de Carvalho
2018-06-26 10:52       ` Ulrich Weigand
2018-06-26 16:53       ` Pedro Alves
2018-06-26 18:49         ` Pedro Franco de Carvalho
2018-06-20 21:09 ` [PATCH 4/4] Variable size for regs mask in collection list Pedro Franco de Carvalho
2018-06-25 10:38   ` Ulrich Weigand
2018-06-26 16:58   ` Pedro Alves
2018-06-26 18:52     ` Pedro Franco de Carvalho
2018-06-20 21:09 ` [PATCH 1/4] Fix indentation in remote_target::download_tracepoint Pedro Franco de Carvalho
2018-06-25 10:32   ` Ulrich Weigand
2018-06-20 21:10 ` [PATCH 2/4] Remove trailing '-' from the last QTDP action packet Pedro Franco de Carvalho
2018-06-25 10:33   ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620210855.6385-1-pedromfc@linux.vnet.ibm.com \
    --to=pedromfc@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).