From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: gdb-patches@sourceware.org
Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Subject: [RFA_v3 6/8] Add a test for 'frame apply'
Date: Sun, 24 Jun 2018 18:37:00 -0000 [thread overview]
Message-ID: <20180624183708.888-7-philippe.waroquiers@skynet.be> (raw)
In-Reply-To: <20180624183708.888-1-philippe.waroquiers@skynet.be>
Add a test for 'frame apply'
gdb/testsuite/ChangeLog
2018-06-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* gdb.base/frameapply.c: New file.
* gdb.base/frameapply.exp: New file.
---
gdb/testsuite/gdb.base/frameapply.c | 71 ++++++++++
gdb/testsuite/gdb.base/frameapply.exp | 179 ++++++++++++++++++++++++++
2 files changed, 250 insertions(+)
create mode 100644 gdb/testsuite/gdb.base/frameapply.c
create mode 100644 gdb/testsuite/gdb.base/frameapply.exp
diff --git a/gdb/testsuite/gdb.base/frameapply.c b/gdb/testsuite/gdb.base/frameapply.c
new file mode 100644
index 0000000000..dccf4031ed
--- /dev/null
+++ b/gdb/testsuite/gdb.base/frameapply.c
@@ -0,0 +1,71 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2018 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+static void
+setup_done (void)
+{
+}
+
+static int
+f1 (int f1arg)
+{
+ int f1loc;
+
+ f1loc = f1arg - 1;
+
+ setup_done ();
+ return f1loc;
+}
+
+static int
+f2 (int f2arg)
+{
+ int f2loc;
+
+ f2loc = f1 (f2arg - 1);
+
+ return f2loc;
+}
+
+static int
+f3 (int f3arg)
+{
+ int f3loc;
+
+ f3loc = f2 (f3arg - 1);
+
+ return f3loc;
+}
+
+static int
+f4 (int f4arg)
+{
+ int f4loc;
+
+ f4loc = f3 (f4arg - 1);
+
+ return f4loc;
+}
+
+int
+main (void)
+{
+ int result;
+
+ result = f4 (4);
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.base/frameapply.exp b/gdb/testsuite/gdb.base/frameapply.exp
new file mode 100644
index 0000000000..1911e15b72
--- /dev/null
+++ b/gdb/testsuite/gdb.base/frameapply.exp
@@ -0,0 +1,179 @@
+# This testcase is part of GDB, the GNU debugger.
+
+# Copyright 2018 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+
+# Test 'frame apply [all | COUNT | -COUNT | id ID...] [FLAG]... COMMAND'
+
+standard_testfile
+
+if { [prepare_for_testing "failed to prepare" ${testfile}] } {
+ return -1
+}
+
+clean_restart ${binfile}
+
+
+if ![runto setup_done] then {
+ gdb_suppress_tests
+}
+
+set any "\[^\r\n\]*"
+set ws "\[ \t\]\+"
+set number "\[0-9]\+"
+
+
+# check all | COUNT | -COUNT | id ID... with a simple command
+foreach cmd {
+ "frame apply all p /x 20"
+ "frame apply id 0-5 p /x 20"
+ "frame apply id 0-3 4-5 p /x 20"
+ "frame apply id 0 1-2 3-5 p /x 20"
+ "frame apply id 0 1 2 3 4 5 p /x 20"
+ "frame apply id 0-0 1-1 2-2 3-3 4-4 5-5 p /x 20" } {
+ gdb_test $cmd \
+ [multi_line \
+ "#0${ws}setup_done ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#1${ws}${any} f1 ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#2${ws}${any} f2 ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#3${ws}${any} f3 ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#4${ws}${any} f4 ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#5${ws}${any} main ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ ] \
+ "Run a simple command on all frames"
+}
+
+foreach cmd {"frame apply 3 p /x 20" "frame apply id 0-2 p /x 20"} {
+ gdb_test $cmd \
+ [multi_line \
+ "#0${ws}setup_done ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#1${ws}${any} f1 ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#2${ws}${any} f2 ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ ] \
+ "Run a simple command on the 3 innermost frames"
+}
+
+gdb_test "frame apply -3 p /x 20" \
+ [multi_line \
+ "#3${ws}${any} f3 ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#4${ws}${any} f4 ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#5${ws}${any} main ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ ] \
+ "Run a simple command on the 3 outermost frames"
+
+# check -c (continue) and -s (silently continue) flags
+foreach cmd {
+ "frame apply all p f3arg"
+ "frame apply id 0-5 p f3arg"} {
+ gdb_test $cmd \
+ [multi_line \
+ "#0${ws}setup_done ${any}" \
+ "No symbol \\\"f3arg\\\" in current context." \
+ ] \
+ "Run a failing command that aborts frame apply"
+}
+
+foreach cmd {
+ "frame apply all -c p f3arg"
+ "frame apply id 0-5 -c p f3arg"} {
+ gdb_test $cmd \
+ [multi_line \
+ "#0${ws}setup_done ${any}" \
+ "No symbol \\\"f3arg\\\" in current context." \
+ "#1${ws}${any} f1 ${any}" \
+ "No symbol \\\"f3arg\\\" in current context." \
+ "#2${ws}${any} f2 ${any}" \
+ "No symbol \\\"f3arg\\\" in current context." \
+ "#3${ws}${any} f3 ${any}" \
+ "\\\$\[0-9]+ = 3${any}" \
+ "#4${ws}${any} f4 ${any}" \
+ "No symbol \\\"f3arg\\\" in current context." \
+ "#5${ws}${any} main ${any}" \
+ "No symbol \\\"f3arg\\\" in current context." \
+ ] \
+ "Run a command failing in all frames except #3, -c to continue"
+}
+
+foreach cmd {
+ "frame apply all -s p f3arg"
+ "faas p f3arg"
+ "frame apply id 0-5 -s p f3arg"} {
+ gdb_test $cmd \
+ [multi_line \
+ "#3${ws}${any} f3 ${any}" \
+ "\\\$\[0-9]+ = 3${any}" \
+ ] \
+ "Run a command failing in all frames except #3, -s to silently continue"
+}
+
+# check quietness
+foreach cmd {
+ "frame apply 2 p /x 20"
+ "frame apply id 0-1 p /x 20"} {
+ gdb_test $cmd \
+ [multi_line \
+ "#0${ws}setup_done ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "#1${ws}${any} f1 ${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ ] \
+ "Run a command, printing location"
+}
+
+foreach cmd {
+ "frame apply 2 -q p /x 20"
+ "frame apply id 0-1 -q p /x 20"} {
+ gdb_test $cmd \
+ [multi_line \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ "\\\$\[0-9]+ = 0x14${any}" \
+ ] \
+ "Run a command with -q quiet flag, printing only command results"
+}
+
+# check multiple flags together
+foreach cmd {
+ "frame apply all -q -s -q p f3arg"
+ "frame apply id 0-5 -q -s -q p f3arg"} {
+ gdb_test $cmd \
+ "\\\$\[0-9]+ = 3${any}" \
+ "Run a command failing in all frames except #3, -s to silently continue, quiet"
+}
+
+# check invalid flag combinations
+gdb_test "frame apply all -c -s p f3arg" \
+ "frame apply all: -c and -s are mutually exclusive" \
+ "Check -c and -s cannot be used simultaneously"
+
+# check some cases of missing or wrong args
+gdb_test "frame apply" "Missing COUNT argument." "missing COUNT"
+gdb_test "frame apply -c" "Invalid COUNT argument." "invalid COUNT arg"
+gdb_test "frame apply id 4-2 p 1" "inverted range" "inverted range"
+gdb_test "frame apply id 0-3" \
+ "Please specify a command to apply on the selected frames" \
+ "missing command"
--
2.17.1
next prev parent reply other threads:[~2018-06-24 18:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 18:37 [RFA_v3 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' Philippe Waroquiers
2018-06-24 18:37 ` [RFA_v3 2/8] Implement frame apply [all | COUNT | -COUNT | id ID... ] [FLAG]... COMMAND Philippe Waroquiers
2018-07-09 19:16 ` Pedro Alves
2018-07-10 21:50 ` Philippe Waroquiers
2018-06-24 18:37 ` [RFA_v3 8/8] Add a self-test for cli-utils.c Philippe Waroquiers
2018-07-09 19:27 ` Pedro Alves
2018-06-24 18:37 ` [RFA_v3 7/8] Modify gdb.threads/pthreads.exp to test FLAG qcs arguments for thread apply Philippe Waroquiers
2018-06-24 18:37 ` [RFA_v3 4/8] Documents the new commands 'frame apply', faas, taas, tfaas Philippe Waroquiers
2018-07-09 19:16 ` Pedro Alves
2018-06-24 18:37 ` [RFA_v3 3/8] Add [FLAG]... arguments to 'thread apply' Philippe Waroquiers
2018-07-09 19:18 ` Pedro Alves
2018-06-24 18:37 ` [RFA_v3 5/8] Announce the user visible changes for frame/thread apply in NEWS Philippe Waroquiers
2018-06-24 18:37 ` [RFA_v3 1/8] Add helper functions parse_flags and parse_flags_qcs Philippe Waroquiers
2018-07-09 19:14 ` Pedro Alves
2018-06-24 18:37 ` Philippe Waroquiers [this message]
2018-07-09 19:19 ` [RFA_v3 6/8] Add a test for 'frame apply' Pedro Alves
2018-06-29 12:22 ` [RFA_v3 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' Andrew Burgess
2018-06-29 20:16 ` Philippe Waroquiers
2018-06-29 20:38 ` Philippe Waroquiers
2018-07-09 19:01 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180624183708.888-7-philippe.waroquiers@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).