From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: palves@redhat.com (Pedro Alves)
Cc: tom@tromey.com (Tom Tromey), gdb-patches@sourceware.org
Subject: Re: [PATCH] Use thread_info and inferior pointers more throughout
Date: Mon, 25 Jun 2018 10:18:00 -0000 [thread overview]
Message-ID: <20180625101758.0639CD801CC@oc3748833570.ibm.com> (raw)
In-Reply-To: <d138ac33-ecb0-46e4-04b9-f221a5713845@redhat.com> from "Pedro Alves" at Jun 21, 2018 05:20:54 PM
Pedro Alves wrote:
> (delete_thread, delete_thread_silent): Take a thread_info pointer
> instead of a ptid.
Looks like not all callers were updated; I'm seeing build bot failures:
gdb/remote-sim.c: In member function 'virtual void gdbsim_target::mourn_inferior()':
gdb/remote-sim.c:1198:50: error: cannot convert 'ptid_t' to 'thread_info*' for argument '1' to 'void delete_thread_silent(thread_info*)'
delete_thread_silent (sim_data->remote_sim_ptid);
Just from grepping, there also seem to be a number of other calls
in native code that were not updated:
go32-nat.c: delete_thread_silent (ptid);
bsd-kvm.c: delete_thread_silent (bsd_kvm_ptid);
darwin-nat.c: delete_thread (ptid_build (inf->pid, 0, old_id));
fbsd-nat.c: delete_thread (wptid);
aix-thread.c: delete_thread (gbuf[gi]->ptid);
aix-thread.c: delete_thread (gptid);
windows-nat.c: delete_thread (ptid);
procfs.c: delete_thread (retval);
procfs.c: delete_thread (retval);
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2018-06-25 10:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 18:07 Pedro Alves
2018-06-07 18:28 ` Tom Tromey
2018-06-21 15:57 ` Pedro Alves
2018-06-21 16:21 ` Pedro Alves
2018-06-25 10:18 ` Ulrich Weigand [this message]
2018-06-25 10:23 ` Pedro Alves
2018-06-27 11:34 ` Ulrich Weigand
2018-06-27 12:43 ` [PATCH] Fix Cell debugging regression (Re: [PATCH] Use thread_info and inferior pointers more throughout) Pedro Alves
2018-06-27 13:12 ` Ulrich Weigand
2018-06-27 13:17 ` Pedro Alves
2018-06-27 15:30 ` [PATCH v2] " Pedro Alves
2018-06-27 16:05 ` Ulrich Weigand
2018-06-27 16:25 ` Pedro Alves
2019-02-14 15:45 ` [PATCH] Use thread_info and inferior pointers more throughout Thomas Schwinge
2018-06-27 18:16 ` Possible regression on gdb.multi/multi-arch-exec.exp (was: Re: [PATCH] Use thread_info and inferior pointers more throughout) Sergio Durigan Junior
2018-06-27 18:39 ` Keith Seitz
2018-06-28 12:09 ` Possible regression on gdb.multi/multi-arch-exec.exp Pedro Alves
2018-06-28 16:02 ` [pushed] Fix follow-exec regression / crash (Re: Possible regression on gdb.multi/multi-arch-exec.exp) Pedro Alves
2018-06-28 16:37 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625101758.0639CD801CC@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).