From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45923 invoked by alias); 27 Jun 2018 11:34:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45886 invoked by uid 89); 27 Jun 2018 11:34:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Cell, operated, instantly, cell X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 11:34:30 +0000 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5RBYII5146796 for ; Wed, 27 Jun 2018 07:34:29 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2jv8n6txab-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 27 Jun 2018 07:34:26 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Jun 2018 12:33:50 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 27 Jun 2018 12:33:48 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w5RBXlBx24969234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 Jun 2018 11:33:47 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9455EA4053; Wed, 27 Jun 2018 12:33:38 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 838E5A4051; Wed, 27 Jun 2018 12:33:38 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.93]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 27 Jun 2018 12:33:38 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 04B6ED801C0; Wed, 27 Jun 2018 13:33:46 +0200 (CEST) Subject: Re: [PATCH] Use thread_info and inferior pointers more throughout To: palves@redhat.com (Pedro Alves) Date: Wed, 27 Jun 2018 11:34:00 -0000 From: "Ulrich Weigand" Cc: tom@tromey.com (Tom Tromey), gdb-patches@sourceware.org In-Reply-To: from "Pedro Alves" at Jun 21, 2018 05:20:54 PM MIME-Version: 1.0 x-cbid: 18062711-0028-0000-0000-000002D579D3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18062711-0029-0000-0000-0000238CE1BA Message-Id: <20180627113347.04B6ED801C0@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-06/txt/msg00635.txt.bz2 Pedro Alves wrote: > ps_err_e > ps_lgetregs (struct ps_prochandle *ph, lwpid_t lwpid, prgregset_t gregset) > { > - ptid_t ptid = ptid_build (ptid_get_pid (ph->ptid), lwpid, 0); > - struct regcache *regcache > - = get_thread_arch_regcache (ptid, target_gdbarch ()); > + struct regcache *regcache = get_thread_regcache (ph->thread); This change (and the related ones in the following routines completely break Cell multi-arch debugging. The point of using get_thread_arch_regcache with target_gdbarch() instead of just plain get_thread_regcache is that the proc-service routines must always operated on the "main" (in this case PowerPC) architecture, because that's the register set libthread_db expects to be using. The change above switches the behavior to use the SPU architecture if GDB happens to interrupt SPU code. This is wrong and causes internal GDB errors pretty much instantly when starting an SPU ... Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com