From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97644 invoked by alias); 27 Jun 2018 16:05:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97629 invoked by uid 89); 27 Jun 2018 16:05:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:846 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 16:05:09 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5RG3daT136569 for ; Wed, 27 Jun 2018 12:05:08 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2jvdc3hejk-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 27 Jun 2018 12:05:07 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Jun 2018 17:05:04 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 27 Jun 2018 17:05:01 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w5RG50Ci23658552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 Jun 2018 16:05:00 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DCF3252059; Wed, 27 Jun 2018 17:04:52 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.93]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id CCC0F52051; Wed, 27 Jun 2018 17:04:52 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 7D77BD80271; Wed, 27 Jun 2018 18:05:00 +0200 (CEST) Subject: Re: [PATCH v2] Fix Cell debugging regression (Re: [PATCH] Use thread_info and inferior pointers more throughout) To: palves@redhat.com (Pedro Alves) Date: Wed, 27 Jun 2018 16:05:00 -0000 From: "Ulrich Weigand" Cc: tom@tromey.com (Tom Tromey), gdb-patches@sourceware.org In-Reply-To: <41f5019d-31a8-8458-1a3b-4c412fd1ddc8@redhat.com> from "Pedro Alves" at Jun 27, 2018 04:30:13 PM MIME-Version: 1.0 x-cbid: 18062716-4275-0000-0000-00000292885F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18062716-4276-0000-0000-00003799F1A4 Message-Id: <20180627160500.7D77BD80271@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-06/txt/msg00654.txt.bz2 Pedro Alves wrote: > Just OOC, I added a assertion like > gdb_assert (lwpid == ph->thread->ptid.lwp ()); > and it didn't trigger on x86-64, I think because libthread_db > on x86-64 uses ps_get_thread_area and doesn't call into these > routines. Maybe it does in some cases, like core debugging. > I didn't run the whole testsuite, only a couple threaded programs. > > Anyways, the assertion did fail on PowerPC. OK, I see. > gdb/ChangeLog: > 2018-06-27 Pedro Alves > > * proc-service.c (get_ps_regcache): New. > (ps_lgetregs, ps_lsetregs, ps_lgetfpregs) > (ps_lsetfpregs): Use it. This looks good to me. Thanks! Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com