From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6303 invoked by alias); 27 Jun 2018 16:29:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6292 invoked by uid 89); 27 Jun 2018 16:29:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 16:29:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2C0C756039; Wed, 27 Jun 2018 12:29:36 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ABCQrktn4amP; Wed, 27 Jun 2018 12:29:36 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 03442117979; Wed, 27 Jun 2018 12:29:35 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3879D87970; Wed, 27 Jun 2018 09:29:34 -0700 (PDT) Date: Wed, 27 Jun 2018 16:29:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: Thomas Petazzoni , gdb-patches@sourceware.org, Pedro Alves Subject: Re: [PATCH] nat/fork-inferior: include linux-ptrace.h Message-ID: <20180627162934.GA18598@adacore.com> References: <20180625080547.7629-1-thomas.petazzoni@bootlin.com> <3acce11a3e5ed352af945ab71739468b@polymtl.ca> <20180627163123.6da3d93c@windsurf.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-06/txt/msg00658.txt.bz2 > > > fork-inferior.c is also included in native builds for BSDs, AIX, > > > Solaris > > > and Darwin (see gdb/configure.nat). I am a bit concerned that > > > linux-ptrace.h could use some Linux-specific things, and thus would > > > break the other builds. However, I built-tested on FreeBSD and it > > > seems > > > fine. Worst case, we can probably wrap this include in "#ifdef > > > __linux__" if that becomes a problem. > > > > Or better, this horrible mess of __UCLIBC__ and HAS_NOMMU macros should > > be replaced by a proper autoconf check testing for the availability of > > fork(). > > Agreed, and I think Pedro will agree too (unless you can think of a simpler > solution that doesn't involve autoconf?). We already autoconf for "fork" (see HAVE_FORK in config.in). Does that help? -- Joel