From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] nat/fork-inferior: include linux-ptrace.h
Date: Wed, 27 Jun 2018 14:31:00 -0000 [thread overview]
Message-ID: <20180627163123.6da3d93c@windsurf.home> (raw)
In-Reply-To: <3acce11a3e5ed352af945ab71739468b@polymtl.ca>
Hello Simon,
On Wed, 27 Jun 2018 10:24:07 -0400, Simon Marchi wrote:
> > diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c
> > index 8b59387fa5..05167628a6 100644
> > --- a/gdb/nat/fork-inferior.c
> > +++ b/gdb/nat/fork-inferior.c
> > @@ -26,6 +26,7 @@
> > #include "common-gdbthread.h"
> > #include "signals-state-save-restore.h"
> > #include "gdb_tilde_expand.h"
> > +#include "linux-ptrace.h"
> > #include <vector>
> >
> > extern char **environ;
>
> Hi Thomas,
>
> fork-inferior.c is also included in native builds for BSDs, AIX, Solaris
> and Darwin (see gdb/configure.nat). I am a bit concerned that
> linux-ptrace.h could use some Linux-specific things, and thus would
> break the other builds. However, I built-tested on FreeBSD and it seems
> fine. Worst case, we can probably wrap this include in "#ifdef
> __linux__" if that becomes a problem.
Or better, this horrible mess of __UCLIBC__ and HAS_NOMMU macros should
be replaced by a proper autoconf check testing for the availability of
fork().
> Do you have push access, or do you prefer if I push the patch for you?
I don't have push access.
> I suppose that error was caught by a Buildroot autobuilder? Would it be
> possible to have the config, so I can add a similar configuration to my
> collection of cross-compiled GDB builds I use for build-testing?
The error wasn't caught by the autobuilders, but by the automated build
logic we use for http://toolchains.bootlin.com to build toolchains for
a wide range of CPU architectures.
The failure was
https://gitlab.com/free-electrons/toolchains-builder/-/jobs/77021057,
and the Buildroot configuration being built was:
BR2_m68k=y
BR2_m68k_cf5208=y
BR2_WGET="wget --passive-ftp -nd -t 3 --no-check-certificate"
BR2_HOST_DIR="/opt/m68k-coldfire--uclibc--bleeding-edge-2018.06-1"
BR2_GNU_MIRROR="http://ftp.gnu.org/pub/gnu"
BR2_KERNEL_HEADERS_4_14=y
BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
BR2_PTHREAD_DEBUG=y
BR2_BINUTILS_VERSION_2_30_X=y
BR2_GCC_VERSION_8_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_HOST_GDB=y
BR2_GDB_VERSION_8_1=y
BR2_INIT_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_GDB=y
# BR2_TARGET_ROOTFS_TAR is not set
Note that with Buildroot's latest master, this configuration will build
fine, because we already merged the fix for the fork/vfork issue.
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-06-27 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 8:05 Thomas Petazzoni
2018-06-27 14:25 ` Simon Marchi
2018-06-27 14:30 ` Pedro Alves
2018-06-27 14:31 ` Thomas Petazzoni [this message]
2018-06-27 14:34 ` Simon Marchi
2018-06-27 16:29 ` Joel Brobecker
2018-06-27 16:32 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627163123.6da3d93c@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).