From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89057 invoked by alias); 29 Jun 2018 12:22:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89044 invoked by uid 89); 29 Jun 2018 12:22:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=D*be, H*r:sk:v16-v6s, HTo:D*be, philippe X-HELO: mail-wm0-f53.google.com Received: from mail-wm0-f53.google.com (HELO mail-wm0-f53.google.com) (74.125.82.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Jun 2018 12:22:02 +0000 Received: by mail-wm0-f53.google.com with SMTP id v16-v6so1990149wmv.5 for ; Fri, 29 Jun 2018 05:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eEl09/V4xKCdWIv00qtyMM1oeindgqGsBQa4mPd/cR8=; b=cZNr/HmUfq5jzRhr72N4Xp+E4oWWndnHvAb32Twj3+KSbH+t/wrsstftgM7+6kVgVN YJfkAO8CK6oEIDzs3ZdcejeI2Fbz4n0/zAM+zhGIbRXYlLmEow3kGHWHNlgq49j1W5OR RRL6b1P3vNaPcFvCfMj079T86ZFdsPnVICUrMNjVCrL4AOqJT02uyT2ECkNRQeDjkrTp cMVWt+OMsMW7Xw72KO8lblC4/1pDFii8fJKfYHzMAU4JVXr3+t0gMqjZcPC84oNTfNdJ Yn3B0uI+BgbL68RhTXpM8XFnJ9kw7J/QuXzCq+b1MAtxGylJAiYeszr0cRUHT/O+57Ng 0DTQ== Return-Path: Received: from localhost (host81-140-212-80.range81-140.btcentralplus.com. [81.140.212.80]) by smtp.gmail.com with ESMTPSA id s124-v6sm1553194wmf.47.2018.06.29.05.21.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Jun 2018 05:21:59 -0700 (PDT) Date: Fri, 29 Jun 2018 12:22:00 -0000 From: Andrew Burgess To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA_v3 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' Message-ID: <20180629122158.GH15881@embecosm.com> References: <20180624183708.888-1-philippe.waroquiers@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180624183708.888-1-philippe.waroquiers@skynet.be> X-Fortune: One planet is all you get. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00710.txt.bz2 * Philippe Waroquiers [2018-06-24 20:37:00 +0200]: > This is the fourth iteration of the patch series that: > * implements a new command > 'frame apply [all | COUNT | -COUNT | id ID...] [FLAG]... COMMAND'. I still have this patch pending (which I need to ping) but I still hope to get it merged: https://sourceware.org/ml/gdb-patches/2018-06/msg00170.html This patch makes it much clearer (I think) that there are multiple was to IDentify a frame, level, address, function-name. I wonder if using the keyword 'id' might be confusing were my patch to end up being merged? Would a consistent 'level' be better? Interested to hear your thoughts... Thanks, Andrew > * enhance 'thread apply COMMAND' by adding FLAG arguments. > * adds some shortcuts commands. > * documents the above in gdb.texinfo and NEWS. > * adds a unit test for cli-utils.c. > * adds test for 'frame apply'. > * modify gdb.threads/pthreads.exp to test 'thread apply' FLAG arguments. > > The fourth version is RFA v3. It handles the comments given by Pedro. > The main changes compared to RFA v2 are: > * The -q (quiet) flag replaces the verbosity/-v/-q concept. > * Addition of 'frame apply id ID... [FLAG]... COMMAND' to allow > applying a command on a selected list of frames. > * [FLAG]... arguments are now parsed iteratively. > * Documentation and on-line help updated accordingly. > * tests updated accordingly. > > The third version was RFA v2, handling the comments of Pedro about giving > the flags individually. > The changes compared to RFA v1 is: > * The flags must be given individually, such as -v -v -c. > * The documentation and on-line help was updated accordingly. > * ChangeLog information is distributed in each commit log message. > > The second version was RFA v1, changes compared to RFC are: > * Replied to all comments of Eli and Simon. > * Tests and ChangeLog entries added. > * Comments received from Pedro > > The first version was an RFC > * Code and doc was complete, but was lacking ChangeLog and tests. > * Comments received from Eli and Simon. > > > > >