> Thanks for writing up the commit log and ChangeLog.  The commit looks
> fine to me, but you should add your name there somewhere too.

I ended up putting my name as the tester. That way, if someone sees
the revision log and wonders what kind of testing was done, he can
contact me. The rest was entirely you, so left you as the sole author.

> One comment on a comment below.
> 
> > diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c
> > index d31d8f1..b562018 100644
> > --- a/gdb/arch/amd64.c
> > +++ b/gdb/arch/amd64.c
> > @@ -33,10 +33,12 @@
> >  
> >  /* Create amd64 target descriptions according to XCR0.  If IS_X32 is
> >     true, create the x32 ones.  If IS_LINUX is true, create target
> > -   descriptions for Linux.  */
> > +   descriptions for Linux.  If SEGMENTS is true, the include the segment
> > +   registers.  */
> 
> "the include" -> "then include"
> 
> I think it'd be clearer to say:
> 
>   include the "org.gnu.gdb.i386.segments" feature registers.
> 
> because "segment registers" along makes one think of cs,ds,ss...,
> but those are part of the core register set.

Makes sense. I made the change you suggested, and corrected the typo
as well, and then pushed the attached patch to master.

gdb/ChangeLog:

        * gdb/amd64-tdep.h (amd64_create_target_description): Add
        "segments" parameter.
        * gdb/amd64-tdep.c (amd64_none_init_abi, amd64_x32_none_init_abi)
        (_initialize_amd64_tdep): Update call to
        amd64_create_target_description.
        (amd64_target_description): Add "segments" parameter.  Adjust
        the implementation to use it.
        * gdb/amd64-linux-tdep.c (amd64_linux_read_description): Update
        call to amd64_create_target_description.
        * gdb/amd64-windows-tdep.c (amd64_windows_init_abi): Likewise.
        * gdb/arch/amd64.h (amd64_create_target_description): Add
        "segments" register.
        * gdb/arch/amd64.c (amd64_create_target_description): Add
        "segments" parameter.  Call create_feature_i386_64bit_segments
        only if SEGMENTS is true.
        * gdb/gdbserver/win32-i386-low.c (i386_arch_setup): Update
        call to amd64_create_target_description.

Thanks a lot for your help!
-- 
Joel