* Breakage on builder Fedora-s390x-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
@ 2018-06-29 22:10 ` gdb-buildbot
2018-06-29 22:10 ` Breakage on builder RHEL-s390x-m64, " gdb-buildbot
` (12 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 22:10 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
marist-fedora-s390x
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/8941>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX mips-nbsd-tdep.o
CXX mips-sde-tdep.o
CXX mips-tdep.o
CXX mn10300-linux-tdep.o
CXX mn10300-tdep.o
CXX moxie-tdep.o
CXX msp430-tdep.o
CXX nbsd-tdep.o
CXX nds32-tdep.o
CXX nios2-linux-tdep.o
CXX nios2-tdep.o
CXX nto-tdep.o
CXX obsd-tdep.o
CXX or1k-tdep.o
CXX ppc-fbsd-tdep.o
CXX ppc-linux-tdep.o
CXX ppc-nbsd-tdep.o
CXX ppc-obsd-tdep.o
CXX ppc-ravenscar-thread.o
CXX ppc-sysv-tdep.o
CXX ppc64-tdep.o
CXX ravenscar-thread.o
CXX riscv-tdep.o
CXX rl78-tdep.o
CXX rs6000-aix-tdep.o
CXX rs6000-lynx178-tdep.o
CXX rs6000-tdep.o
CXX rx-tdep.o
CXX s390-linux-tdep.o
CXX s390-tdep.o
CXX score-tdep.o
CXX sh-linux-tdep.o
CXX sh-nbsd-tdep.o
CXX sh-tdep.o
CXX sol2-tdep.o
CXX solib-aix.o
CXX solib-darwin.o
CXX solib-dsbt.o
CXX solib-frv.o
CXX solib-spu.o
CXX solib-svr4.o
CXX sparc-linux-tdep.o
CXX sparc-nbsd-tdep.o
CXX sparc-obsd-tdep.o
CXX sparc-ravenscar-thread.o
CXX sparc-sol2-tdep.o
CXX sparc-tdep.o
CXX spu-multiarch.o
CXX spu-tdep.o
CXX symfile-mem.o
CXX tic6x-linux-tdep.o
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function void x86_darwin_init_abi_64(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-darwin-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function void amd64_dicos_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-dicos-tdep.o] Error 1
make[2]: Leaving directory '/home/mjw/gdb/build/fedora-s390x/build/gdb'
make[1]: *** [Makefile:8793: all-gdb] Error 2
make[1]: Leaving directory '/home/mjw/gdb/build/fedora-s390x/build'
make: *** [Makefile:850: all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder RHEL-s390x-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
2018-06-29 22:10 ` Breakage on builder Fedora-s390x-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da gdb-buildbot
@ 2018-06-29 22:10 ` gdb-buildbot
2018-06-29 22:12 ` Breakage on builder NetBSD-x86_64-m64, " gdb-buildbot
` (11 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 22:10 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
rhel-7_1-s390x-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/7621>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX sparc-ravenscar-thread.o
CXX sparc-sol2-tdep.o
CXX sparc-tdep.o
CXX spu-multiarch.o
CXX spu-tdep.o
CXX symfile-mem.o
CXX tic6x-linux-tdep.o
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
CXX amd64-linux-tdep.o
CXX amd64-nbsd-tdep.o
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function void amd64_dicos_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
CXX amd64-obsd-tdep.o
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function void x86_darwin_init_abi_64(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
make[2]: *** [amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [amd64-darwin-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function void amd64fbsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:160:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1plus: all warnings being treated as errors
make[2]: *** [amd64-fbsd-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-nbsd-tdep.c: In function void amd64nbsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-nbsd-tdep.c:108:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-nbsd-tdep.c:27:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-obsd-tdep.c: In function void amd64obsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-obsd-tdep.c:424:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-obsd-tdep.c:33:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
make[2]: *** [amd64-nbsd-tdep.o] Error 1
make[2]: *** [amd64-obsd-tdep.o] Error 1
make[2]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `/home/dje/rhel-7_1-s390x-1/rhel-s390x/build'
make: *** [all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate
@ 2018-06-29 22:10 gdb-buildbot
2018-06-29 22:10 ` Breakage on builder Fedora-s390x-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da gdb-buildbot
` (13 more replies)
0 siblings, 14 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 22:10 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
My lords, ladies, gentlemen, members of the public.
It is a matter of great regret and sadness to inform you that commit:
x86_64-windows GDB crash due to fs_base/gs_base registers
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
might have made GDB unwell. Since I am just your Butler BuildBot,
I kindly ask that a human superior officer double-check this.
Please note that if you are reading this message on gdb-patches, there might
be other builders broken.
You can find more details about the unfortunate breakage in the next messages.
Cheers,
Your GDB BuildBot.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder NetBSD-x86_64-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
2018-06-29 22:10 ` Breakage on builder Fedora-s390x-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da gdb-buildbot
2018-06-29 22:10 ` Breakage on builder RHEL-s390x-m64, " gdb-buildbot
@ 2018-06-29 22:12 ` gdb-buildbot
2018-06-29 22:21 ` Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate Joel Brobecker
` (10 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 22:12 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
gdb-amd64-netbsd7
Full Build URL:
<http://gdb-build.sergiodj.net/builders/NetBSD-x86_64-m64/builds/4750>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/NetBSD-x86_64-m64/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
GEN c++defs.h
GEN arg-nonnull.h
GEN warn-on-use.h
GEN dirent.h
GEN errno.h
GEN fcntl.h
GEN fnmatch.h
GEN glob.h
GEN inttypes.h
GEN limits.h
GEN math.h
GEN signal.h
GEN stdint.h
GEN stdio.h
GEN stdlib.h
GEN string.h
GEN sys/stat.h
GEN sys/time.h
GEN sys/types.h
GEN time.h
GEN unistd.h
GEN wchar.h
GEN wctype.h
gmake all-recursive
gmake[7]: Entering directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib/import'
gmake[8]: Entering directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib/import'
CC cloexec.o
CC dirname-lgpl.o
CC basename-lgpl.o
CC stripslash.o
CC exitfail.o
CC fd-hook.o
CC filenamecat-lgpl.o
CC getprogname.o
CC hard-locale.o
CC localcharset.o
CC malloca.o
CC math.o
CC openat-die.o
CC save-cwd.o
CC strnlen1.o
CC tempname.o
CC unistd.o
CC dup-safer.o
CC fd-safer.o
CC pipe-safer.o
CC wctype-h.o
CC canonicalize-lgpl.o
CC chdir-long.o
CC error.o
CC fnmatch.o
CC getcwd.o
CC getcwd-lgpl.o
CC glob.o
CC memmem.o
CC mempcpy.o
CC openat-proc.o
CC rawmemchr.o
CC rename.o
CC secure_getenv.o
CC strerror.o
CC strerror-override.o
CC strstr.o
AR libgnu.a
GEN charset.alias
GEN ref-add.sed
GEN ref-del.sed
gmake[8]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib/import'
gmake[7]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib/import'
gmake[6]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib/import'
gmake[5]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib'
gmake[4]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib'
gmake[3]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb'
CXX gdb.o
CXX i386-tdep.o
CXX arch/i386.o
CXX i387-tdep.o
CXX x86-tdep.o
CXX amd64-tdep.o
CXX arch/amd64.o
CXX nbsd-tdep.o
CXX solib-svr4.o
CXX amd64-nbsd-tdep.o
../../binutils-gdb/gdb/amd64-nbsd-tdep.c: In function 'void amd64nbsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-nbsd-tdep.c:108:50: error: too few arguments to function 'const target_desc* amd64_target_description(__uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-nbsd-tdep.c:27:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
Makefile:1619: recipe for target 'amd64-nbsd-tdep.o' failed
gmake[2]: *** [amd64-nbsd-tdep.o] Error 1
gmake[2]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb'
Makefile:8791: recipe for target 'all-gdb' failed
gmake[1]: *** [all-gdb] Error 2
gmake[1]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build'
Makefile:848: recipe for target 'all' failed
gmake: *** [all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (2 preceding siblings ...)
2018-06-29 22:12 ` Breakage on builder NetBSD-x86_64-m64, " gdb-buildbot
@ 2018-06-29 22:21 ` Joel Brobecker
2018-06-29 22:53 ` Joel Brobecker
2018-06-29 22:58 ` Breakage on builder Fedora-x86_64-m32, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da gdb-buildbot
` (9 subsequent siblings)
13 siblings, 1 reply; 19+ messages in thread
From: Joel Brobecker @ 2018-06-29 22:21 UTC (permalink / raw)
To: gdb-buildbot; +Cc: Pedro Alves, gdb-patches
> My lords, ladies, gentlemen, members of the public.
>
> It is a matter of great regret and sadness to inform you that commit:
>
> x86_64-windows GDB crash due to fs_base/gs_base registers
> de52b9607d2623f18b7a7dbee3e1123d8d63f5da
>
> might have made GDB unwell. Since I am just your Butler BuildBot,
> I kindly ask that a human superior officer double-check this.
>
> Please note that if you are reading this message on gdb-patches, there might
> be other builders broken.
>
> You can find more details about the unfortunate breakage in the next messages.
That must be me, so I will take a look now. I think it's because
I didn't build with --enable-targets=all.
--
Joel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate
2018-06-29 22:21 ` Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate Joel Brobecker
@ 2018-06-29 22:53 ` Joel Brobecker
2018-06-29 23:22 ` Sergio Durigan Junior
0 siblings, 1 reply; 19+ messages in thread
From: Joel Brobecker @ 2018-06-29 22:53 UTC (permalink / raw)
To: gdb-buildbot; +Cc: Pedro Alves, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
> That must be me, so I will take a look now. I think it's because
> I didn't build with --enable-targets=all.
Attached is the patch I just pushed to master.
gdb/ChangeLog:
* amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
parameter in call to amd64_target_description.
* amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
* amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
(amd64fbsd_init_abi): Likewise.
* amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
* amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
* amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
* amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
The change to amd64-fbsd-nat.c was done "blind" (no access to system),
but is reasonably straightforward. The changes to the -tdep.c files
were verify by rebuilding GDB on x86_64-linux when configured with
--enable-targets=all.
--
Joel
[-- Attachment #2: 0001-fix-GDB-build-failure-for-various-amd64-targets.patch --]
[-- Type: text/x-diff, Size: 6522 bytes --]
From 41206e32fb909ebacf6db009fc1f177bde74a652 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Fri, 29 Jun 2018 18:42:27 -0400
Subject: [PATCH] fix GDB build failure for various amd64 targets
The following patch caused some amd64-*-tdep files to fail to compile:
| commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da
| Date: Tue Jun 26 16:33:27 2018 +0100
| Subject: x86_64-windows GDB crash due to fs_base/gs_base registers
This is because we added one additional "segments" argument to
function amd64_target_description and forgot to update all the callers.
This patch fixes the omissions.
gdb/ChangeLog:
* amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
parameter in call to amd64_target_description.
* amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
* amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
(amd64fbsd_init_abi): Likewise.
* amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
* amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
* amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
* amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
The change to amd64-fbsd-nat.c was done "blind" (no access to system),
but is reasonably straightforward. The changes to the -tdep.c files
were verify by rebuilding GDB on x86_64-linux when configured with
--enable-targets=all.
---
gdb/ChangeLog | 12 ++++++++++++
gdb/amd64-darwin-tdep.c | 2 +-
gdb/amd64-dicos-tdep.c | 2 +-
gdb/amd64-fbsd-nat.c | 4 ++--
gdb/amd64-fbsd-tdep.c | 4 ++--
gdb/amd64-nbsd-tdep.c | 2 +-
gdb/amd64-obsd-tdep.c | 2 +-
gdb/amd64-sol2-tdep.c | 2 +-
8 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c47c111466..e3267853d3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,15 @@
+2018-06-29 Joel Brobecker <brobecker@adacore.com>
+
+ * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
+ parameter in call to amd64_target_description.
+ * amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
+ * amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
+ (amd64fbsd_init_abi): Likewise.
+ * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
+ * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
+ * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
+ * amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
+
2018-06-29 Pedro Alves <palves@redhat.com>
* gdb/amd64-tdep.h (amd64_create_target_description): Add
diff --git a/gdb/amd64-darwin-tdep.c b/gdb/amd64-darwin-tdep.c
index fe8bfab721..24d21b9f4a 100644
--- a/gdb/amd64-darwin-tdep.c
+++ b/gdb/amd64-darwin-tdep.c
@@ -100,7 +100,7 @@ x86_darwin_init_abi_64 (struct gdbarch_info info, struct gdbarch *gdbarch)
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
amd64_init_abi (info, gdbarch,
- amd64_target_description (X86_XSTATE_SSE_MASK));
+ amd64_target_description (X86_XSTATE_SSE_MASK, true));
tdep->struct_return = reg_struct_return;
diff --git a/gdb/amd64-dicos-tdep.c b/gdb/amd64-dicos-tdep.c
index 85861ec86e..a9af7a0461 100644
--- a/gdb/amd64-dicos-tdep.c
+++ b/gdb/amd64-dicos-tdep.c
@@ -27,7 +27,7 @@ static void
amd64_dicos_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
amd64_init_abi (info, gdbarch,
- amd64_target_description (X86_XSTATE_SSE_MASK));
+ amd64_target_description (X86_XSTATE_SSE_MASK, true));
dicos_init_abi (gdbarch);
}
diff --git a/gdb/amd64-fbsd-nat.c b/gdb/amd64-fbsd-nat.c
index 6b0367b5d6..f9b1bcae2e 100644
--- a/gdb/amd64-fbsd-nat.c
+++ b/gdb/amd64-fbsd-nat.c
@@ -188,13 +188,13 @@ amd64_fbsd_nat_target::read_description ()
if (x86bsd_xsave_len != 0)
{
if (is64)
- return amd64_target_description (xcr0);
+ return amd64_target_description (xcr0, true);
else
return i386_target_description (xcr0);
}
#endif
if (is64)
- return amd64_target_description (X86_XSTATE_SSE_MASK);
+ return amd64_target_description (X86_XSTATE_SSE_MASK, true);
else
return i386_target_description (X86_XSTATE_SSE_MASK);
}
diff --git a/gdb/amd64-fbsd-tdep.c b/gdb/amd64-fbsd-tdep.c
index 9b2ee13653..f5bf1985b6 100644
--- a/gdb/amd64-fbsd-tdep.c
+++ b/gdb/amd64-fbsd-tdep.c
@@ -156,7 +156,7 @@ amd64fbsd_core_read_description (struct gdbarch *gdbarch,
struct target_ops *target,
bfd *abfd)
{
- return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
+ return amd64_target_description (i386fbsd_core_read_xcr0 (abfd), true);
}
/* Similar to amd64_supply_fpregset, but use XSAVE extended state. */
@@ -218,7 +218,7 @@ amd64fbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
tdep->sizeof_gregset = 22 * 8;
amd64_init_abi (info, gdbarch,
- amd64_target_description (X86_XSTATE_SSE_MASK));
+ amd64_target_description (X86_XSTATE_SSE_MASK, true));
tdep->sigtramp_p = amd64fbsd_sigtramp_p;
tdep->sigtramp_start = amd64fbsd_sigtramp_start_addr;
diff --git a/gdb/amd64-nbsd-tdep.c b/gdb/amd64-nbsd-tdep.c
index f740bb4a82..d100beacd1 100644
--- a/gdb/amd64-nbsd-tdep.c
+++ b/gdb/amd64-nbsd-tdep.c
@@ -105,7 +105,7 @@ amd64nbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
tdep->sizeof_gregset = 26 * 8;
amd64_init_abi (info, gdbarch,
- amd64_target_description (X86_XSTATE_SSE_MASK));
+ amd64_target_description (X86_XSTATE_SSE_MASK, true));
tdep->jb_pc_offset = 7 * 8;
diff --git a/gdb/amd64-obsd-tdep.c b/gdb/amd64-obsd-tdep.c
index 1e078b14f8..da4739c972 100644
--- a/gdb/amd64-obsd-tdep.c
+++ b/gdb/amd64-obsd-tdep.c
@@ -421,7 +421,7 @@ amd64obsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
amd64_init_abi (info, gdbarch,
- amd64_target_description (X86_XSTATE_SSE_MASK));
+ amd64_target_description (X86_XSTATE_SSE_MASK, true));
obsd_init_abi (info, gdbarch);
/* Initialize general-purpose register set details. */
diff --git a/gdb/amd64-sol2-tdep.c b/gdb/amd64-sol2-tdep.c
index 78d3d361cb..9504f190d7 100644
--- a/gdb/amd64-sol2-tdep.c
+++ b/gdb/amd64-sol2-tdep.c
@@ -101,7 +101,7 @@ amd64_sol2_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
tdep->sizeof_gregset = 28 * 8;
amd64_init_abi (info, gdbarch,
- amd64_target_description (X86_XSTATE_SSE_MASK));
+ amd64_target_description (X86_XSTATE_SSE_MASK, true));
tdep->sigtramp_p = amd64_sol2_sigtramp_p;
tdep->sigcontext_addr = amd64_sol2_mcontext_addr;
--
2.17.1
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Fedora-x86_64-m32, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (3 preceding siblings ...)
2018-06-29 22:21 ` Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate Joel Brobecker
@ 2018-06-29 22:58 ` gdb-buildbot
2018-06-29 23:02 ` Breakage on builder Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
` (8 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 22:58 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
fedora-x86-64-4
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/9927>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX ppc-ravenscar-thread.o
CXX ppc-sysv-tdep.o
CXX ppc64-tdep.o
CXX ravenscar-thread.o
CXX riscv-tdep.o
CXX rl78-tdep.o
CXX rs6000-aix-tdep.o
CXX rs6000-lynx178-tdep.o
CXX rs6000-tdep.o
CXX rx-tdep.o
CXX s390-linux-tdep.o
CXX s390-tdep.o
CXX score-tdep.o
CXX sh-linux-tdep.o
CXX sh-nbsd-tdep.o
CXX sh-tdep.o
CXX sol2-tdep.o
CXX solib-aix.o
CXX solib-darwin.o
CXX solib-dsbt.o
CXX solib-frv.o
CXX solib-spu.o
CXX solib-svr4.o
CXX sparc-linux-tdep.o
CXX sparc-nbsd-tdep.o
CXX sparc-obsd-tdep.o
CXX sparc-ravenscar-thread.o
CXX sparc-sol2-tdep.o
CXX sparc-tdep.o
CXX spu-multiarch.o
CXX spu-tdep.o
CXX symfile-mem.o
CXX tic6x-linux-tdep.o
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function void amd64_dicos_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function void x86_darwin_init_abi_64(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function void amd64fbsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-fbsd-tdep.o] Error 1
make[2]: *** [Makefile:1622: amd64-darwin-tdep.o] Error 1
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-m32/build/gdb'
make[1]: *** [Makefile:8793: all-gdb] Error 2
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-m32/build'
make: *** [Makefile:850: all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Fedora-x86_64-native-extended-gdbserver-m32, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (4 preceding siblings ...)
2018-06-29 22:58 ` Breakage on builder Fedora-x86_64-m32, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da gdb-buildbot
@ 2018-06-29 23:02 ` gdb-buildbot
2018-06-29 23:05 ` Breakage on builder Fedora-x86_64-cc-with-index, " gdb-buildbot
` (7 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 23:02 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
fedora-x86-64-4
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/9915>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX ppc-ravenscar-thread.o
CXX ppc-sysv-tdep.o
CXX ppc64-tdep.o
CXX ravenscar-thread.o
CXX riscv-tdep.o
CXX rl78-tdep.o
CXX rs6000-aix-tdep.o
CXX rs6000-lynx178-tdep.o
CXX rs6000-tdep.o
CXX rx-tdep.o
CXX s390-linux-tdep.o
CXX s390-tdep.o
CXX score-tdep.o
CXX sh-linux-tdep.o
CXX sh-nbsd-tdep.o
CXX sh-tdep.o
CXX sol2-tdep.o
CXX solib-aix.o
CXX solib-darwin.o
CXX solib-dsbt.o
CXX solib-frv.o
CXX solib-spu.o
CXX solib-svr4.o
CXX sparc-linux-tdep.o
CXX sparc-nbsd-tdep.o
CXX sparc-obsd-tdep.o
CXX sparc-ravenscar-thread.o
CXX sparc-sol2-tdep.o
CXX sparc-tdep.o
CXX spu-multiarch.o
CXX spu-tdep.o
CXX symfile-mem.o
CXX tic6x-linux-tdep.o
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function void amd64_dicos_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function void x86_darwin_init_abi_64(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-darwin-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function void amd64fbsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-fbsd-tdep.o] Error 1
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-extended-gdbserver-m32/build/gdb'
make[1]: *** [Makefile:8793: all-gdb] Error 2
make: *** [Makefile:850: all] Error 2
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-extended-gdbserver-m32/build'
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Fedora-x86_64-cc-with-index, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (5 preceding siblings ...)
2018-06-29 23:02 ` Breakage on builder Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
@ 2018-06-29 23:05 ` gdb-buildbot
2018-06-29 23:08 ` Breakage on builder Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
` (6 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 23:05 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
fedora-x86-64-4
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/10094>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX ppc-ravenscar-thread.o
CXX ppc-sysv-tdep.o
CXX ppc64-tdep.o
CXX ravenscar-thread.o
CXX riscv-tdep.o
CXX rl78-tdep.o
CXX rs6000-aix-tdep.o
CXX rs6000-lynx178-tdep.o
CXX rs6000-tdep.o
CXX rx-tdep.o
CXX s390-linux-tdep.o
CXX s390-tdep.o
CXX score-tdep.o
CXX sh-linux-tdep.o
CXX sh-nbsd-tdep.o
CXX sh-tdep.o
CXX sol2-tdep.o
CXX solib-aix.o
CXX solib-darwin.o
CXX solib-dsbt.o
CXX solib-frv.o
CXX solib-spu.o
CXX solib-svr4.o
CXX sparc-linux-tdep.o
CXX sparc-nbsd-tdep.o
CXX sparc-obsd-tdep.o
CXX sparc-ravenscar-thread.o
CXX sparc-sol2-tdep.o
CXX sparc-tdep.o
CXX spu-multiarch.o
CXX spu-tdep.o
CXX symfile-mem.o
CXX tic6x-linux-tdep.o
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function void amd64_dicos_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function void x86_darwin_init_abi_64(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function void amd64fbsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-darwin-tdep.o] Error 1
make[2]: *** [Makefile:1622: amd64-fbsd-tdep.o] Error 1
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-cc-with-index/build/gdb'
make[1]: *** [Makefile:8793: all-gdb] Error 2
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-cc-with-index/build'
make: *** [Makefile:850: all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Fedora-x86_64-native-gdbserver-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (6 preceding siblings ...)
2018-06-29 23:05 ` Breakage on builder Fedora-x86_64-cc-with-index, " gdb-buildbot
@ 2018-06-29 23:08 ` gdb-buildbot
2018-06-29 23:09 ` Breakage on builder Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
` (5 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 23:08 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
fedora-x86-64-4
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/10138>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX ppc-ravenscar-thread.o
CXX ppc-sysv-tdep.o
CXX ppc64-tdep.o
CXX ravenscar-thread.o
CXX riscv-tdep.o
CXX rl78-tdep.o
CXX rs6000-aix-tdep.o
CXX rs6000-lynx178-tdep.o
CXX rs6000-tdep.o
CXX rx-tdep.o
CXX s390-linux-tdep.o
CXX s390-tdep.o
CXX score-tdep.o
CXX sh-linux-tdep.o
CXX sh-nbsd-tdep.o
CXX sh-tdep.o
CXX sol2-tdep.o
CXX solib-aix.o
CXX solib-darwin.o
CXX solib-dsbt.o
CXX solib-frv.o
CXX solib-spu.o
CXX solib-svr4.o
CXX sparc-linux-tdep.o
CXX sparc-nbsd-tdep.o
CXX sparc-obsd-tdep.o
CXX sparc-ravenscar-thread.o
CXX sparc-sol2-tdep.o
CXX sparc-tdep.o
CXX spu-multiarch.o
CXX spu-tdep.o
CXX symfile-mem.o
CXX tic6x-linux-tdep.o
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function void amd64_dicos_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function void x86_darwin_init_abi_64(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function void amd64fbsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-fbsd-tdep.o] Error 1
make[2]: *** [Makefile:1622: amd64-darwin-tdep.o] Error 1
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-gdbserver/build/gdb'
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-gdbserver/build'
make[1]: *** [Makefile:8793: all-gdb] Error 2
make: *** [Makefile:850: all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Fedora-x86_64-native-extended-gdbserver-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (7 preceding siblings ...)
2018-06-29 23:08 ` Breakage on builder Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
@ 2018-06-29 23:09 ` gdb-buildbot
2018-06-29 23:11 ` Breakage on builder Fedora-x86_64-m64, " gdb-buildbot
` (4 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 23:09 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
fedora-x86-64-2
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/10185>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX ppc-ravenscar-thread.o
CXX ppc-sysv-tdep.o
CXX ppc64-tdep.o
CXX ravenscar-thread.o
CXX riscv-tdep.o
CXX rl78-tdep.o
CXX rs6000-aix-tdep.o
CXX rs6000-lynx178-tdep.o
CXX rs6000-tdep.o
CXX rx-tdep.o
CXX s390-linux-tdep.o
CXX s390-tdep.o
CXX score-tdep.o
CXX sh-linux-tdep.o
CXX sh-nbsd-tdep.o
CXX sh-tdep.o
CXX sol2-tdep.o
CXX solib-aix.o
CXX solib-darwin.o
CXX solib-dsbt.o
CXX solib-frv.o
CXX solib-spu.o
CXX solib-svr4.o
CXX sparc-linux-tdep.o
CXX sparc-nbsd-tdep.o
CXX sparc-obsd-tdep.o
CXX sparc-ravenscar-thread.o
CXX sparc-sol2-tdep.o
CXX sparc-tdep.o
CXX spu-multiarch.o
CXX spu-tdep.o
CXX symfile-mem.o
CXX tic6x-linux-tdep.o
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function void x86_darwin_init_abi_64(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
CXX amd64-fbsd-tdep.o
make[2]: *** [Makefile:1622: amd64-darwin-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function void amd64_dicos_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-dicos-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function void amd64fbsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-fbsd-tdep.o] Error 1
make[1]: *** [Makefile:8793: all-gdb] Error 2
make: *** [Makefile:850: all] Error 2
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-native-extended-gdbserver/build/gdb'
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64-native-extended-gdbserver/build'
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Fedora-x86_64-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (8 preceding siblings ...)
2018-06-29 23:09 ` Breakage on builder Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
@ 2018-06-29 23:11 ` gdb-buildbot
2018-06-29 23:22 ` Breakage on builder Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
` (3 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 23:11 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
fedora-x86-64-4
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/10204>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX ppc-ravenscar-thread.o
CXX ppc-sysv-tdep.o
CXX ppc64-tdep.o
CXX ravenscar-thread.o
CXX riscv-tdep.o
CXX rl78-tdep.o
CXX rs6000-aix-tdep.o
CXX rs6000-lynx178-tdep.o
CXX rs6000-tdep.o
CXX rx-tdep.o
CXX s390-linux-tdep.o
CXX s390-tdep.o
CXX score-tdep.o
CXX sh-linux-tdep.o
CXX sh-nbsd-tdep.o
CXX sh-tdep.o
CXX sol2-tdep.o
CXX solib-aix.o
CXX solib-darwin.o
CXX solib-dsbt.o
CXX solib-frv.o
CXX solib-spu.o
CXX solib-svr4.o
CXX sparc-linux-tdep.o
CXX sparc-nbsd-tdep.o
CXX sparc-obsd-tdep.o
CXX sparc-ravenscar-thread.o
CXX sparc-sol2-tdep.o
CXX sparc-tdep.o
CXX spu-multiarch.o
CXX spu-tdep.o
CXX symfile-mem.o
CXX tic6x-linux-tdep.o
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function void amd64_dicos_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function void x86_darwin_init_abi_64(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-darwin-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function void amd64fbsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-fbsd-tdep.o] Error 1
make[2]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64/build/gdb'
make[1]: *** [Makefile:8793: all-gdb] Error 2
make[1]: Leaving directory '/home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64/build'
make: *** [Makefile:850: all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate
2018-06-29 22:53 ` Joel Brobecker
@ 2018-06-29 23:22 ` Sergio Durigan Junior
2018-06-29 23:35 ` Joel Brobecker
0 siblings, 1 reply; 19+ messages in thread
From: Sergio Durigan Junior @ 2018-06-29 23:22 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Pedro Alves, gdb-patches
On Friday, June 29 2018, Joel Brobecker wrote:
>> That must be me, so I will take a look now. I think it's because
>> I didn't build with --enable-targets=all.
>
> Attached is the patch I just pushed to master.
>
> gdb/ChangeLog:
>
> * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
> parameter in call to amd64_target_description.
> * amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
> * amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
> (amd64fbsd_init_abi): Likewise.
> * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
> * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
> * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
> * amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
>
> The change to amd64-fbsd-nat.c was done "blind" (no access to system),
> but is reasonably straightforward. The changes to the -tdep.c files
> were verify by rebuilding GDB on x86_64-linux when configured with
> --enable-targets=all.
Hey Joel,
I'm still seeing a breakage here on x86-64 Fedora GNU/Linux, when
building gdbserver:
../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c: In function ‘const target_desc* amd64_linux_read_description(uint64_t, bool)’:
../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c:121:67: error: too few arguments to function ‘target_desc* amd64_create_target_description(uint64_t, bool, bool, bool)’
*tdesc = amd64_create_target_description (xcr0, is_x32, true);
^
In file included from ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c:26:0:
../../../binutils-gdb/gdb/gdbserver/../arch/amd64.h:21:14: note: declared here
target_desc *amd64_create_target_description (uint64_t xcr0, bool is_x32,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Does the patch below make sense? It fixes the breakage for me.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 2fd2d90a49..743d465d81 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2018-06-29 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ * linux-x86-tdesc.c (amd64_linux_read_description): Add missing
+ parameter in call to 'amd64_create_target_description'.
+
2018-06-28 Jan Kratochvil <jan.kratochvil@redhat.com>
* x86-tdesc.h: Remove executable permission flag.
diff --git a/gdb/gdbserver/linux-x86-tdesc.c b/gdb/gdbserver/linux-x86-tdesc.c
index 358659b295..7a45953dc9 100644
--- a/gdb/gdbserver/linux-x86-tdesc.c
+++ b/gdb/gdbserver/linux-x86-tdesc.c
@@ -118,7 +118,7 @@ amd64_linux_read_description (uint64_t xcr0, bool is_x32)
if (*tdesc == NULL)
{
- *tdesc = amd64_create_target_description (xcr0, is_x32, true);
+ *tdesc = amd64_create_target_description (xcr0, is_x32, true, false);
init_target_desc (*tdesc, amd64_expedite_regs);
}
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Fedora-x86_64-native-gdbserver-m32, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (9 preceding siblings ...)
2018-06-29 23:11 ` Breakage on builder Fedora-x86_64-m64, " gdb-buildbot
@ 2018-06-29 23:22 ` gdb-buildbot
2018-06-29 23:42 ` Breakage on builder Debian-s390x-native-gdbserver-m64, " gdb-buildbot
` (2 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 23:22 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
fedora-x86-64-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/9913>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m32/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX ppc-ravenscar-thread.o
CXX ppc-sysv-tdep.o
CXX ppc64-tdep.o
CXX ravenscar-thread.o
CXX riscv-tdep.o
CXX rl78-tdep.o
CXX rs6000-aix-tdep.o
CXX rs6000-lynx178-tdep.o
CXX rs6000-tdep.o
CXX rx-tdep.o
CXX s390-linux-tdep.o
CXX s390-tdep.o
CXX score-tdep.o
CXX sh-linux-tdep.o
CXX sh-nbsd-tdep.o
CXX sh-tdep.o
CXX sol2-tdep.o
CXX solib-aix.o
CXX solib-darwin.o
CXX solib-dsbt.o
CXX solib-frv.o
CXX solib-spu.o
CXX solib-svr4.o
CXX sparc-linux-tdep.o
CXX sparc-nbsd-tdep.o
CXX sparc-obsd-tdep.o
CXX sparc-ravenscar-thread.o
CXX sparc-sol2-tdep.o
CXX sparc-tdep.o
CXX spu-multiarch.o
CXX spu-tdep.o
CXX symfile-mem.o
CXX tic6x-linux-tdep.o
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function void amd64_dicos_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function void x86_darwin_init_abi_64(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-darwin-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function void amd64fbsd_init_abi(gdbarch_info, gdbarch*):
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function const target_desc* amd64_target_description(uint64_t, bool)
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1622: amd64-fbsd-tdep.o] Error 1
make[2]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-1/fedora-x86-64-native-gdbserver-m32/build/gdb'
make[1]: *** [Makefile:8793: all-gdb] Error 2
make[1]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-1/fedora-x86-64-native-gdbserver-m32/build'
make: *** [Makefile:850: all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate
2018-06-29 23:22 ` Sergio Durigan Junior
@ 2018-06-29 23:35 ` Joel Brobecker
2018-06-30 1:39 ` Sergio Durigan Junior
0 siblings, 1 reply; 19+ messages in thread
From: Joel Brobecker @ 2018-06-29 23:35 UTC (permalink / raw)
To: Sergio Durigan Junior; +Cc: Pedro Alves, gdb-patches
> I'm still seeing a breakage here on x86-64 Fedora GNU/Linux, when
> building gdbserver:
>
> ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c: In function ‘const target_desc* amd64_linux_read_description(uint64_t, bool)’:
> ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c:121:67: error: too few arguments to function ‘target_desc* amd64_create_target_description(uint64_t, bool, bool, bool)’
> *tdesc = amd64_create_target_description (xcr0, is_x32, true);
> ^
> In file included from ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c:26:0:
> ../../../binutils-gdb/gdb/gdbserver/../arch/amd64.h:21:14: note: declared here
> target_desc *amd64_create_target_description (uint64_t xcr0, bool is_x32,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Does the patch below make sense? It fixes the breakage for me.
Thanks for looking into it and the patch!
I think the parameter should be set to "true". Otherwise, it will
not include the fs_base and gs_base register in the list of registers.
Although the name of the source file says x86, the code itself is
protected by...
#ifdef __x86_64__
... and is inside a function called amd64_linux_read_description.
I also verified that this file gets compiled on amd64-linux platforms.
See gdb/gdbserver/configure.srv:
x86_64-*-linux*) srv_regobj="$srv_amd64_linux_regobj $srv_i386_linux_regobj"
The last piece of confirmation is that setting the parameter to "true"
provides the behavior before the parameter was added; and the reason
for adding the parameter was to remove the {fs,gs}_base registers
from the list for Windows only.
Otherwise the rest (basically the ChangeLog) looks good.
Thanks again!
> diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
> index 2fd2d90a49..743d465d81 100644
> --- a/gdb/gdbserver/ChangeLog
> +++ b/gdb/gdbserver/ChangeLog
> @@ -1,3 +1,8 @@
> +2018-06-29 Sergio Durigan Junior <sergiodj@redhat.com>
> +
> + * linux-x86-tdesc.c (amd64_linux_read_description): Add missing
> + parameter in call to 'amd64_create_target_description'.
> +
> 2018-06-28 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * x86-tdesc.h: Remove executable permission flag.
> diff --git a/gdb/gdbserver/linux-x86-tdesc.c b/gdb/gdbserver/linux-x86-tdesc.c
> index 358659b295..7a45953dc9 100644
> --- a/gdb/gdbserver/linux-x86-tdesc.c
> +++ b/gdb/gdbserver/linux-x86-tdesc.c
> @@ -118,7 +118,7 @@ amd64_linux_read_description (uint64_t xcr0, bool is_x32)
>
> if (*tdesc == NULL)
> {
> - *tdesc = amd64_create_target_description (xcr0, is_x32, true);
> + *tdesc = amd64_create_target_description (xcr0, is_x32, true, false);
>
> init_target_desc (*tdesc, amd64_expedite_regs);
> }
--
Joel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Debian-s390x-native-gdbserver-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (10 preceding siblings ...)
2018-06-29 23:22 ` Breakage on builder Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
@ 2018-06-29 23:42 ` gdb-buildbot
2018-06-29 23:44 ` Breakage on builder Debian-s390x-m64, " gdb-buildbot
2018-06-29 23:46 ` Breakage on builder Debian-s390x-native-extended-gdbserver-m64, " gdb-buildbot
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 23:42 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
debian-jessie-s390x-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-gdbserver-m64/builds/5788>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Debian-s390x-native-gdbserver-m64/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xtensa-config.o
CXX xstormy16-tdep.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
CXX amd64-linux-tdep.o
CXX amd64-nbsd-tdep.o
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function 'void x86_darwin_init_abi_64(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function 'void amd64_dicos_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
CXX amd64-obsd-tdep.o
Makefile:1622: recipe for target 'amd64-dicos-tdep.o' failed
make[2]: *** [amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Makefile:1622: recipe for target 'amd64-darwin-tdep.o' failed
make[2]: *** [amd64-darwin-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function 'const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*)':
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function 'void amd64fbsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function 'const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*)':
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:160:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1plus: all warnings being treated as errors
Makefile:1622: recipe for target 'amd64-fbsd-tdep.o' failed
make[2]: *** [amd64-fbsd-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-nbsd-tdep.c: In function 'void amd64nbsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-nbsd-tdep.c:108:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-nbsd-tdep.c:27:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
Makefile:1622: recipe for target 'amd64-nbsd-tdep.o' failed
make[2]: *** [amd64-nbsd-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-obsd-tdep.c: In function 'void amd64obsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-obsd-tdep.c:424:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-obsd-tdep.c:33:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
Makefile:1622: recipe for target 'amd64-obsd-tdep.o' failed
make[2]: *** [amd64-obsd-tdep.o] Error 1
make[2]: Leaving directory '/home/dje/debian-jessie-s390x-1/debian-s390x-native-gdbserver/build/gdb'
Makefile:8792: recipe for target 'all-gdb' failed
make[1]: Leaving directory '/home/dje/debian-jessie-s390x-1/debian-s390x-native-gdbserver/build'
Makefile:849: recipe for target 'all' failed
make[1]: *** [all-gdb] Error 2
make: *** [all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Debian-s390x-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (11 preceding siblings ...)
2018-06-29 23:42 ` Breakage on builder Debian-s390x-native-gdbserver-m64, " gdb-buildbot
@ 2018-06-29 23:44 ` gdb-buildbot
2018-06-29 23:46 ` Breakage on builder Debian-s390x-native-extended-gdbserver-m64, " gdb-buildbot
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 23:44 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
debian-jessie-s390x-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/5744>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Debian-s390x-m64/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
CXX amd64-linux-tdep.o
CXX amd64-nbsd-tdep.o
CXX amd64-obsd-tdep.o
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function 'void x86_darwin_init_abi_64(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function 'void amd64_dicos_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
Makefile:1622: recipe for target 'amd64-dicos-tdep.o' failed
make[2]: *** [amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Makefile:1622: recipe for target 'amd64-darwin-tdep.o' failed
make[2]: *** [amd64-darwin-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function 'const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*)':
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function 'void amd64fbsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function 'const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*)':
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:160:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1plus: all warnings being treated as errors
Makefile:1622: recipe for target 'amd64-fbsd-tdep.o' failed
make[2]: *** [amd64-fbsd-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-nbsd-tdep.c: In function 'void amd64nbsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-nbsd-tdep.c:108:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-nbsd-tdep.c:27:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
Makefile:1622: recipe for target 'amd64-nbsd-tdep.o' failed
make[2]: *** [amd64-nbsd-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-obsd-tdep.c: In function 'void amd64obsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-obsd-tdep.c:424:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-obsd-tdep.c:33:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
Makefile:1622: recipe for target 'amd64-obsd-tdep.o' failed
make[2]: *** [amd64-obsd-tdep.o] Error 1
make[2]: Leaving directory '/home/dje/debian-jessie-s390x-1/debian-s390x/build/gdb'
Makefile:8792: recipe for target 'all-gdb' failed
make[1]: Leaving directory '/home/dje/debian-jessie-s390x-1/debian-s390x/build'
make[1]: *** [all-gdb] Error 2
Makefile:849: recipe for target 'all' failed
make: *** [all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Breakage on builder Debian-s390x-native-extended-gdbserver-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
` (12 preceding siblings ...)
2018-06-29 23:44 ` Breakage on builder Debian-s390x-m64, " gdb-buildbot
@ 2018-06-29 23:46 ` gdb-buildbot
13 siblings, 0 replies; 19+ messages in thread
From: gdb-buildbot @ 2018-06-29 23:46 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Unfortunately it seems that there is a breakage on GDB.
Commit title: 'x86_64-windows GDB crash due to fs_base/gs_base registers'
Revision: de52b9607d2623f18b7a7dbee3e1123d8d63f5da
You can find more details below:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Buildslave:
debian-jessie-s390x-1
Full Build URL:
<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/5934>
Commit(s) tested:
de52b9607d2623f18b7a7dbee3e1123d8d63f5da
Author(s) (in the same order as the commits):
Pedro Alves <palves@redhat.com>
Subject:
x86_64-windows GDB crash due to fs_base/gs_base registers
Testsuite log (gdb.sum and gdb.log) URL(s):
<http://gdb-build.sergiodj.net/results/Debian-s390x-native-extended-gdbserver-m64/de/de52b9607d2623f18b7a7dbee3e1123d8d63f5da/>
*** Failed to compiled GDB. ***
============================
+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.
CXX tic6x-tdep.o
CXX tilegx-linux-tdep.o
CXX tilegx-tdep.o
CXX v850-tdep.o
CXX vax-nbsd-tdep.o
CXX vax-tdep.o
CXX windows-tdep.o
CXX x86-tdep.o
CXX xcoffread.o
CXX xstormy16-tdep.o
CXX xtensa-config.o
CXX xtensa-linux-tdep.o
CXX xtensa-tdep.o
CXX aarch64-fbsd-tdep.o
CXX aarch64-linux-tdep.o
CXX aarch64-newlib-tdep.o
CXX aarch64-tdep.o
CXX alpha-bsd-tdep.o
CXX alpha-linux-tdep.o
CXX alpha-mdebug-tdep.o
CXX alpha-nbsd-tdep.o
CXX alpha-obsd-tdep.o
CXX alpha-tdep.o
CXX amd64-darwin-tdep.o
CXX amd64-dicos-tdep.o
CXX amd64-fbsd-tdep.o
CXX amd64-linux-tdep.o
CXX amd64-nbsd-tdep.o
CXX amd64-obsd-tdep.o
../../binutils-gdb/gdb/amd64-dicos-tdep.c: In function 'void amd64_dicos_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-dicos-tdep.c:30:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-dicos-tdep.c:22:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-darwin-tdep.c: In function 'void x86_darwin_init_abi_64(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-darwin-tdep.c:103:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-darwin-tdep.c:32:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
Makefile:1622: recipe for target 'amd64-dicos-tdep.o' failed
make[2]: *** [amd64-dicos-tdep.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Makefile:1622: recipe for target 'amd64-darwin-tdep.o' failed
make[2]: *** [amd64-darwin-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function 'const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*)':
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:159:66: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
return amd64_target_description (i386fbsd_core_read_xcr0 (abfd));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function 'void amd64fbsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:221:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-fbsd-tdep.c:30:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-fbsd-tdep.c: In function 'const target_desc* amd64fbsd_core_read_description(gdbarch*, target_ops*, bfd*)':
../../binutils-gdb/gdb/amd64-fbsd-tdep.c:160:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1plus: all warnings being treated as errors
Makefile:1622: recipe for target 'amd64-fbsd-tdep.o' failed
make[2]: *** [amd64-fbsd-tdep.o] Error 1
../../binutils-gdb/gdb/amd64-nbsd-tdep.c: In function 'void amd64nbsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-nbsd-tdep.c:108:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-nbsd-tdep.c:27:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
../../binutils-gdb/gdb/amd64-obsd-tdep.c: In function 'void amd64obsd_init_abi(gdbarch_info, gdbarch*)':
../../binutils-gdb/gdb/amd64-obsd-tdep.c:424:50: error: too few arguments to function 'const target_desc* amd64_target_description(uint64_t, bool)'
amd64_target_description (X86_XSTATE_SSE_MASK));
^
In file included from ../../binutils-gdb/gdb/amd64-obsd-tdep.c:33:0:
../../binutils-gdb/gdb/amd64-tdep.h:109:34: note: declared here
extern const struct target_desc *amd64_target_description (uint64_t xcr0,
^
Makefile:1622: recipe for target 'amd64-nbsd-tdep.o' failed
make[2]: *** [amd64-nbsd-tdep.o] Error 1
Makefile:1622: recipe for target 'amd64-obsd-tdep.o' failed
make[2]: *** [amd64-obsd-tdep.o] Error 1
make[2]: Leaving directory '/home/dje/debian-jessie-s390x-1/debian-s390x-native-extended-gdbserver/build/gdb'
Makefile:8792: recipe for target 'all-gdb' failed
make[1]: Leaving directory '/home/dje/debian-jessie-s390x-1/debian-s390x-native-extended-gdbserver/build'
Makefile:849: recipe for target 'all' failed
make[1]: *** [all-gdb] Error 2
make: *** [all] Error 2
============================
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate
2018-06-29 23:35 ` Joel Brobecker
@ 2018-06-30 1:39 ` Sergio Durigan Junior
0 siblings, 0 replies; 19+ messages in thread
From: Sergio Durigan Junior @ 2018-06-30 1:39 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Pedro Alves, gdb-patches
On Friday, June 29 2018, Joel Brobecker wrote:
>> I'm still seeing a breakage here on x86-64 Fedora GNU/Linux, when
>> building gdbserver:
>>
>> ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c: In function ‘const target_desc* amd64_linux_read_description(uint64_t, bool)’:
>> ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c:121:67: error: too few arguments to function ‘target_desc* amd64_create_target_description(uint64_t, bool, bool, bool)’
>> *tdesc = amd64_create_target_description (xcr0, is_x32, true);
>> ^
>> In file included from ../../../binutils-gdb/gdb/gdbserver/linux-x86-tdesc.c:26:0:
>> ../../../binutils-gdb/gdb/gdbserver/../arch/amd64.h:21:14: note: declared here
>> target_desc *amd64_create_target_description (uint64_t xcr0, bool is_x32,
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Does the patch below make sense? It fixes the breakage for me.
>
> Thanks for looking into it and the patch!
>
> I think the parameter should be set to "true". Otherwise, it will
> not include the fs_base and gs_base register in the list of registers.
> Although the name of the source file says x86, the code itself is
> protected by...
>
> #ifdef __x86_64__
>
> ... and is inside a function called amd64_linux_read_description.
> I also verified that this file gets compiled on amd64-linux platforms.
> See gdb/gdbserver/configure.srv:
>
> x86_64-*-linux*) srv_regobj="$srv_amd64_linux_regobj $srv_i386_linux_regobj"
>
> The last piece of confirmation is that setting the parameter to "true"
> provides the behavior before the parameter was added; and the reason
> for adding the parameter was to remove the {fs,gs}_base registers
> from the list for Windows only.
>
> Otherwise the rest (basically the ChangeLog) looks good.
Ah, thanks for the explanation. I should have investigated more before
sending the patch; I was doing something else and just wanted to make
GDB compile again. Glad I sent it here for your review!
> Thanks again!
No, I thank you!
I pushed the patch with s/false/true/, and your name in the ChangeLog.
>> diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
>> index 2fd2d90a49..743d465d81 100644
>> --- a/gdb/gdbserver/ChangeLog
>> +++ b/gdb/gdbserver/ChangeLog
>> @@ -1,3 +1,8 @@
>> +2018-06-29 Sergio Durigan Junior <sergiodj@redhat.com>
>> +
>> + * linux-x86-tdesc.c (amd64_linux_read_description): Add missing
>> + parameter in call to 'amd64_create_target_description'.
>> +
>> 2018-06-28 Jan Kratochvil <jan.kratochvil@redhat.com>
>>
>> * x86-tdesc.h: Remove executable permission flag.
>> diff --git a/gdb/gdbserver/linux-x86-tdesc.c b/gdb/gdbserver/linux-x86-tdesc.c
>> index 358659b295..7a45953dc9 100644
>> --- a/gdb/gdbserver/linux-x86-tdesc.c
>> +++ b/gdb/gdbserver/linux-x86-tdesc.c
>> @@ -118,7 +118,7 @@ amd64_linux_read_description (uint64_t xcr0, bool is_x32)
>>
>> if (*tdesc == NULL)
>> {
>> - *tdesc = amd64_create_target_description (xcr0, is_x32, true);
>> + *tdesc = amd64_create_target_description (xcr0, is_x32, true, false);
>>
>> init_target_desc (*tdesc, amd64_expedite_regs);
>> }
>
> --
> Joel
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2018-06-30 1:39 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-29 22:10 Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate gdb-buildbot
2018-06-29 22:10 ` Breakage on builder Fedora-s390x-m64, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da gdb-buildbot
2018-06-29 22:10 ` Breakage on builder RHEL-s390x-m64, " gdb-buildbot
2018-06-29 22:12 ` Breakage on builder NetBSD-x86_64-m64, " gdb-buildbot
2018-06-29 22:21 ` Oh dear. I regret to inform you that commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da might be unfortunate Joel Brobecker
2018-06-29 22:53 ` Joel Brobecker
2018-06-29 23:22 ` Sergio Durigan Junior
2018-06-29 23:35 ` Joel Brobecker
2018-06-30 1:39 ` Sergio Durigan Junior
2018-06-29 22:58 ` Breakage on builder Fedora-x86_64-m32, revision de52b9607d2623f18b7a7dbee3e1123d8d63f5da gdb-buildbot
2018-06-29 23:02 ` Breakage on builder Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2018-06-29 23:05 ` Breakage on builder Fedora-x86_64-cc-with-index, " gdb-buildbot
2018-06-29 23:08 ` Breakage on builder Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2018-06-29 23:09 ` Breakage on builder Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2018-06-29 23:11 ` Breakage on builder Fedora-x86_64-m64, " gdb-buildbot
2018-06-29 23:22 ` Breakage on builder Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2018-06-29 23:42 ` Breakage on builder Debian-s390x-native-gdbserver-m64, " gdb-buildbot
2018-06-29 23:44 ` Breakage on builder Debian-s390x-m64, " gdb-buildbot
2018-06-29 23:46 ` Breakage on builder Debian-s390x-native-extended-gdbserver-m64, " gdb-buildbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).