New ARI warning Thu Jul 5 02:17:13 UTC 2018 in gdb-8.2-branch

New ARI warning Thu Jul 5 02:17:13 UTC 2018 in gdb-8.2-branch

[GDB Administrator]

38,40d37
< gdb/build-id.c:103: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/build-id.c:103:      s += sprintf (s, ');
< gdb/build-id.c:107: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/build-id.c:107:	  s += sprintf (s, ', (unsigned) *data++);
< gdb/build-id.c:112: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/build-id.c:112:	s += sprintf (s, ', (unsigned) *data++);
47d43
< gdb/cli/cli-decode.c:1442: deprecated: deprecated warn_user: Do not use deprecated warn_user, see declaration for details
gdb/cli/cli-decode.c:1442:      if (found->deprecated_warn_user)
54a51,52
> gdb/cli/cli-decode.h:61: regression: var_boolean: Replace var_boolean with add_setshow_boolean_cmd
gdb/cli/cli-decode.h:61:	var_type (var_boolean),
> gdb/cli/cli-decode.h:94: deprecated: deprecated warn_user: Do not use deprecated warn_user, see declaration for details
gdb/cli/cli-decode.h:94:    unsigned int deprecated_warn_user : 1;
117a116,117
> gdb/cp-name-parser.y:34: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/cp-name-parser.y:34:%pure-parser
> gdb/cp-name-parser.y:36: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/cp-name-parser.y:36:%parse-param {struct cpname_state *state}
184d183
< gdb/ft32-tdep.c:625: deprecate: read_pc: Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this
gdb/ft32-tdep.c:625:  set_gdbarch_read_pc (gdbarch, ft32_read_pc);
gdb/ft32-tdep.c:625:  set_gdbarch_read_pc (gdbarch, ft32_read_pc);
300d298
< gdb/m2-exp.y:911: code: OP eol: Do not use &&, or || at the end of a line
gdb/m2-exp.y:911:		   (*p < '.' || *p > '.') &&
306d303
< gdb/m32r-tdep.c:915: deprecate: read_pc: Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this
gdb/m32r-tdep.c:915:  set_gdbarch_read_pc (gdbarch, m32r_read_pc);
gdb/m32r-tdep.c:915:  set_gdbarch_read_pc (gdbarch, m32r_read_pc);
320d316
< gdb/mep-tdep.c:2449: deprecate: read_pc: Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this
gdb/mep-tdep.c:2449:  set_gdbarch_read_pc (gdbarch, mep_read_pc);
gdb/mep-tdep.c:2449:  set_gdbarch_read_pc (gdbarch, mep_read_pc);
336,337d331
< gdb/mn10300-tdep.c:1426: deprecate: read_pc: Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this
gdb/mn10300-tdep.c:1426:  set_gdbarch_read_pc (gdbarch, mn10300_read_pc);
gdb/mn10300-tdep.c:1426:  set_gdbarch_read_pc (gdbarch, mn10300_read_pc);
< gdb/moxie-tdep.c:1112: deprecate: read_pc: Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this
gdb/moxie-tdep.c:1112:  set_gdbarch_read_pc (gdbarch, moxie_read_pc);
gdb/moxie-tdep.c:1112:  set_gdbarch_read_pc (gdbarch, moxie_read_pc);
339,345d332
< gdb/mt-tdep.c:205: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/mt-tdep.c:205:    sprintf (name, ', dim_1, dim_2, stub);
< gdb/mt-tdep.c:563: code: long long: Do not use 'long long', instead use LONGEST
gdb/mt-tdep.c:563:	    (oldmac & 0xffffffff) | ((long long) (ext_mac & 0xff) << 32);
< gdb/mt-tdep.c:695: deprecated: deprecated frame_register_read: Do not use deprecated frame_register_read, see declaration for details
gdb/mt-tdep.c:695:	  deprecated_frame_register_read (frame, regnum, buff);
< gdb/mt-tdep.c:740: deprecated: deprecated frame_register_read: Do not use deprecated frame_register_read, see declaration for details
gdb/mt-tdep.c:740:	  deprecated_frame_register_read (frame, MT_MAC_REGNUM, buf);
< gdb/mt-tdep.c:746: deprecated: deprecated frame_register_read: Do not use deprecated frame_register_read, see declaration for details
gdb/mt-tdep.c:746:	      deprecated_frame_register_read (frame, MT_EXMAC_REGNUM, buf);
< gdb/mt-tdep.c:981: code: OP eol: Do not use &&, or || at the end of a line
gdb/mt-tdep.c:981:	  if (upper_half == 0x05dd ||	 
< gdb/mt-tdep.c:988: code: OP eol: Do not use &&, or || at the end of a line
gdb/mt-tdep.c:988:	  if ((upper_half & 0xfff0) == 0x43c0 ||	 
403d389
< gdb/ppc-linux-nat.c:842: code: OP eol: Do not use &&, or || at the end of a line
gdb/ppc-linux-nat.c:842:  regcache_raw_collect (regcache, regno, regs +
421d406
< gdb/procfs.c:1608: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:1608:  if ((fd = open_with_retry (pathname, O_RDONLY)) < 0)
431d415
< gdb/procfs.c:1963: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:1963:  if ((pi = create_procinfo (ptid_get_pid (ptid), 0)) == NULL)
436d419
< gdb/procfs.c:2379: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2379:		    if ((nsysargs = proc_nsysarg (pi)) > 0 &&
455d437
< gdb/procfs.c:3475: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:3475:    if ((funcstat = (*func) (prmap, child_func, data)) != 0)
470d451
< gdb/remote-fileio.c:1050: code: OP eol: Do not use &&, or || at the end of a line
gdb/remote-fileio.c:1050:  remote_fileio_return_success (fd == FIO_FD_CONSOLE_IN ||
481,482d461
< gdb/remote.c:7771: code: editCase function: Function name starts lower case but has uppercased letters.
gdb/remote.c:7771:store_register_using_P (const struct regcache *regcache, 			struct packet_reg *reg)
< gdb/remote.c:7812: code: editCase function: Function name starts lower case but has uppercased letters.
gdb/remote.c:7812:store_registers_using_G (const struct regcache *regcache)
487d465
< gdb/remote.c:11569: code: editCase function: Function name starts lower case but has uppercased letters.
gdb/remote.c:11569:remote_hostio_pread_vFile (struct target_ops *self,			   int fd, gdb_byte *read_buf, int len,			   ULONGEST offset, int *remote_errno)
553,554d530
< gdb/sh64-tdep.c:1926: deprecated: deprecated frame_register_read: Do not use deprecated frame_register_read, see declaration for details
gdb/sh64-tdep.c:1926:  if (!deprecated_frame_register_read (frame, regnum, raw_buffer))
< gdb/sh64-tdep.c:2411: legacy: legacy register_sim_regno: Do not use legacy register_sim_regno, see declaration for details
gdb/sh64-tdep.c:2411:  set_gdbarch_register_sim_regno (gdbarch, legacy_register_sim_regno);
gdb/sh64-tdep.c:2411:  set_gdbarch_register_sim_regno (gdbarch, legacy_register_sim_regno);