From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1931 invoked by alias); 19 Jul 2018 14:53:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1894 invoked by uid 89); 19 Jul 2018 14:53:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Jul 2018 14:53:47 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 17BA6AE4C for ; Thu, 19 Jul 2018 14:53:45 +0000 (UTC) Date: Thu, 19 Jul 2018 14:53:00 -0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [OB PATCH][testsuite] Fix regexp in list-thread-groups-available.exp Message-ID: <20180719145356.fl3qn5axxyfxuwkg@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170912 (1.9.0) X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00581.txt.bz2 Hi, I ran into a gdb.mi/list-thread-groups-available.exp failure: ... Running gdb/testsuite/gdb.mi/list-thread-groups-available.exp ... FAIL: gdb.mi/list-thread-groups-available.exp: list available thread groups (unexpected output) PASS: gdb.mi/list-thread-groups-available.exp: list available thread groups with filter ... When doing an experiment of running it 100 times in a row, the failure reproduced 3 times. Analyzing the original failure led to insufficient quoting of square brackets in a regexp. This patch fixes the regexp, which resulted in 0 failures in a 100-in-a-row run. Tested on x86_64-linux. Committed as obvious. Thanks, - Tom [gdb/testsuite] Fix regexp in list-thread-groups-available.exp 2018-07-19 Tom de Vries * gdb.mi/list-thread-groups-available.exp (cores_re): Fix quoting in regular expression. --- gdb/testsuite/gdb.mi/list-thread-groups-available.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp index 7fd0ea223a..c4dab2a2c3 100644 --- a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp +++ b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp @@ -45,7 +45,7 @@ set id_re "id=\"$decimal\"" set type_re "type=\"process\"" set description_re "description=\"$string_re\"" set user_re "user=\"$string_re\"" -set cores_re "cores=\[\"$decimal\"(,\"$decimal\")*\]" +set cores_re "cores=\\\[\"$decimal\"(,\"$decimal\")*\\\]" # List all available processes. set process_entry_re "{${id_re},${type_re}(,$description_re)?(,$user_re)?(,$cores_re)?}"