public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA v2 05/13] Call some functions in guile/ for effect
Date: Sat, 21 Jul 2018 18:47:00 -0000	[thread overview]
Message-ID: <20180721184720.3263-6-tom@tromey.com> (raw)
In-Reply-To: <20180721184720.3263-1-tom@tromey.com>

This changes a couple of spots in guile/ to remove a variable
declaration but to still call a function for effect.

gdb/ChangeLog
2018-07-21  Tom Tromey  <tom@tromey.com>

	* guile/scm-cmd.c (gdbscm_dont_repeat): Call
	cmdscm_get_valid_command_smob_arg_unsafe for effect.
	* guile/scm-block.c (gdbscm_make_block_syms_iter): Call
	bkscm_get_valid_block_smob_arg_unsafe for effect.
---
 gdb/ChangeLog         | 7 +++++++
 gdb/guile/scm-block.c | 5 ++---
 gdb/guile/scm-cmd.c   | 6 +++---
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/gdb/guile/scm-block.c b/gdb/guile/scm-block.c
index d4566fc1ffe..9caff799dc1 100644
--- a/gdb/guile/scm-block.c
+++ b/gdb/guile/scm-block.c
@@ -613,9 +613,8 @@ bkscm_block_syms_progress_p (SCM scm)
 static SCM
 gdbscm_make_block_syms_iter (SCM self)
 {
-  block_smob *b_smob
-    = bkscm_get_valid_block_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
-  const struct block *block = b_smob->block;
+  /* Call for side effects.  */
+  bkscm_get_valid_block_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
   SCM progress, iter;
 
   progress = bkscm_make_block_syms_progress_smob ();
diff --git a/gdb/guile/scm-cmd.c b/gdb/guile/scm-cmd.c
index 88a98643a91..4291933e40e 100644
--- a/gdb/guile/scm-cmd.c
+++ b/gdb/guile/scm-cmd.c
@@ -267,9 +267,9 @@ gdbscm_command_valid_p (SCM self)
 static SCM
 gdbscm_dont_repeat (SCM self)
 {
-  /* We currently don't need anything from SELF, but still verify it.  */
-  command_smob *c_smob
-    = cmdscm_get_valid_command_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
+  /* We currently don't need anything from SELF, but still verify it.
+     Call for side effects.  */
+  cmdscm_get_valid_command_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
 
   dont_repeat ();
 
-- 
2.13.6

  reply	other threads:[~2018-07-21 18:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 18:47 [RFA v2 00/13] Add -Wunused-variable Tom Tromey
2018-07-21 18:47 ` Tom Tromey [this message]
2018-07-21 18:47 ` [RFA v2 07/13] Call value_fetch_lazy when needed in pretty-printers Tom Tromey
2018-07-21 18:47 ` [RFA v2 13/13] Add -Wunused-variable to warnings.m4 Tom Tromey
2018-07-21 18:47 ` [RFA v2 08/13] Fix ravenscar-thread.c to use arch_ops Tom Tromey
2018-07-21 18:47 ` [RFA v2 01/13] Simple unused variable removals Tom Tromey
2018-07-22  2:04   ` Simon Marchi
2018-07-21 18:47 ` [RFA v2 10/13] Remove unused declaration from value.c Tom Tromey
2018-07-22  2:13   ` Simon Marchi
2018-07-21 18:47 ` [RFA v2 03/13] Unused variable fixes related to conditional compilation Tom Tromey
2018-07-21 18:47 ` [RFA v2 02/13] Remove an unused variable from spu_get_overlay_table Tom Tromey
2018-07-22  2:06   ` Simon Marchi
2018-07-22 18:59     ` Ulrich Weigand
2018-07-21 18:47 ` [RFA v2 06/13] Remove dead code from m32c-tdep.c Tom Tromey
2018-07-22  2:10   ` Simon Marchi
2018-07-21 18:47 ` [RFA v2 11/13] Remove unused variables from gdbserver Tom Tromey
2018-07-21 18:47 ` [RFA v2 04/13] Use a previously unused variable in bfin-tdep.c Tom Tromey
2018-07-21 18:47 ` [RFA v2 09/13] Pass the correct argument to the observer in reread_symbols Tom Tromey
2018-07-21 18:47 ` [RFA v2 12/13] Conditionally define xmltarget_${name} variable in regdat.sh Tom Tromey
2018-07-22  2:26 ` [RFA v2 00/13] Add -Wunused-variable Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180721184720.3263-6-tom@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).