From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4250 invoked by alias); 22 Jul 2018 18:59:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4239 invoked by uid 89); 22 Jul 2018 18:59:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:D*ca, HContent-Transfer-Encoding:8bit X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 22 Jul 2018 18:59:32 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6MIwSMW144401 for ; Sun, 22 Jul 2018 14:59:30 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2kcjaf3kr2-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 22 Jul 2018 14:59:30 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 22 Jul 2018 19:59:29 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 22 Jul 2018 19:59:26 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6MIxPVC37945454 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 22 Jul 2018 18:59:25 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A8BCF11C04C; Sun, 22 Jul 2018 21:59:40 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8BBFD11C04A; Sun, 22 Jul 2018 21:59:40 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.164.181.252]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Sun, 22 Jul 2018 21:59:40 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id DDCFDD80290; Sun, 22 Jul 2018 20:59:23 +0200 (CEST) Subject: Re: [RFA v2 02/13] Remove an unused variable from spu_get_overlay_table To: simark@simark.ca (Simon Marchi) Date: Sun, 22 Jul 2018 18:59:00 -0000 From: "Ulrich Weigand" Cc: tom@tromey.com (Tom Tromey), gdb-patches@sourceware.org In-Reply-To: <9cc5720c-62f2-7e01-3294-afb41530d249@simark.ca> from "Simon Marchi" at Jul 21, 2018 10:06:12 PM MIME-Version: 1.0 x-cbid: 18072218-0008-0000-0000-000002562C49 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18072218-0009-0000-0000-000021BC9575 Message-Id: <20180722185923.DDCFDD80290@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00654.txt.bz2 Simon Marchi wrote: > On 2018-07-21 02:47 PM, Tom Tromey wrote: > > This removes an unused variable from spu_get_overlay_table, replacing > > it with an explanatory comment. > > LGTM, but let's ping Ulrich just to be sure. Yes, this is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com