From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15738 invoked by alias); 2 Aug 2018 00:07:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15728 invoked by uid 89); 2 Aug 2018 00:07:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=simon.marchi@ericsson.com, simonmarchiericssoncom, manipulations, HX-Greylist:Thu X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Aug 2018 00:07:13 +0000 Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20DE28762F; Thu, 2 Aug 2018 00:07:12 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-57.phx2.redhat.com [10.3.116.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E86579D474; Thu, 2 Aug 2018 00:07:11 +0000 (UTC) Date: Thu, 02 Aug 2018 00:07:00 -0000 From: Kevin Buettner To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/8] Use BLOCK_ENTRY_PC in place of most uses of BLOCK_START Message-ID: <20180801170710.3fe13c6c@pinnacle.lan> In-Reply-To: <8376825d-5715-2065-d3b7-134eeaf61fa7@ericsson.com> References: <20180625233239.49dc52ea@pinnacle.lan> <20180625235145.3cbf43ff@pinnacle.lan> <8376825d-5715-2065-d3b7-134eeaf61fa7@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00030.txt.bz2 On Tue, 31 Jul 2018 22:21:46 -0400 Simon Marchi wrote: > On 2018-06-26 02:51 AM, Kevin Buettner wrote: > > This change/patch substitues BLOCK_ENTRY_PC for BLOCK_START in > > places where BLOCK_START is used to obtain the address at which > > execution should enter the block. Since blocks can now contain > > non-contiguous ranges, the BLOCK_START - which is still be the > > very lowest address in the block - might not be the same as > > BLOCK_ENTRY_PC. > > > > There is a change to infrun.c which is less obvious and less mechanical. > > I'm posting it as a separate patch. > > Hi Kevin, > > I haven't "gotten" yet when we want to use BLOCK_START and when we want > to use BLOCK_ENTRY_PC. I understand the difference between them, but > don't quite understand how to know which is the one we want. It might > become clearer as I keep reading. I trust you know what you are doing > anyway, so I assume the patch is good :). Once these patches go in, use of BLOCK_START will almost always be wrong. Exceptions are instances where you're doing some manipulations of the block or cases where you (for some reason) need to know the lowest address in the block. Kevin