public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
To: gdb-patches@sourceware.org
Cc: uweigand@de.ibm.com, edjunior@gmail.com
Subject: [PATCH v3 11/12] [PowerPC] Reject tdescs with VSX and no FPU or Altivec
Date: Tue, 14 Aug 2018 20:07:00 -0000	[thread overview]
Message-ID: <20180814200609.19999-12-pedromfc@linux.ibm.com> (raw)
In-Reply-To: <20180814200609.19999-1-pedromfc@linux.ibm.com>

Currently rs6000_gdbarch_init will accept a tdesc with the
"org.gnu.gdb.power.vsx" feature but without the
"org.gnu.gdb.power.altivec" or "org.gnu.gdb.power.fpu".

It isn't clear from the standard features documentation that these are
requirements.  However, these tdescs would cause trouble in the VSX
pseudo-register functions, so this patch will cause them to be
rejected.

gdb/ChangeLog:
YYYY-MM-DD  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>

	* rs6000-tdep.c (rs6000_gdbarch_init): Reject tdescs with vsx but
	without altivec or fpu.
---
 gdb/rs6000-tdep.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index a4998c1a39..8920a18089 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -6044,7 +6044,8 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 	    valid_p &= tdesc_numbered_register (feature, tdesc_data,
 						PPC_VSR0_UPPER_REGNUM + i,
 						vsx_regs[i]);
-	  if (!valid_p)
+
+	  if (!valid_p || !have_fpu || !have_altivec)
 	    {
 	      tdesc_data_cleanup (tdesc_data);
 	      return NULL;
-- 
2.13.6

  parent reply	other threads:[~2018-08-14 20:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14 20:07 [PATCH v3 00/12] GDB support for more powerpc registers on linux Pedro Franco de Carvalho
2018-08-14 20:07 ` [PATCH v3 12/12] [PowerPC] Add support for HTM registers Pedro Franco de Carvalho
2018-08-14 20:07 ` [PATCH v3 08/12] [PowerPC] Add support for PPR and DSCR Pedro Franco de Carvalho
2018-08-14 20:07 ` [PATCH v3 05/12] [PowerPC] Fix two if statements in gdb/ppc-linux-nat.c Pedro Franco de Carvalho
2018-08-14 20:07 ` [PATCH v3 03/12] Add decfloat registers to float reggroup Pedro Franco de Carvalho
2018-08-14 20:07 ` Pedro Franco de Carvalho [this message]
2018-08-14 20:07 ` [PATCH v3 04/12] [PowerPC] Remove rs6000_pseudo_register_reggroup_p Pedro Franco de Carvalho
2018-08-14 20:07 ` [PATCH v3 07/12] [PowerPC] Refactor have_ initializers in rs6000-tdep.c Pedro Franco de Carvalho
2018-08-14 20:07 ` [PATCH v3 01/12] Zero-initialize linux note sections Pedro Franco de Carvalho
2018-08-14 20:07 ` [PATCH v3 06/12] [PowerPC] Fix indentation in arch/ppc-linux-common.c Pedro Franco de Carvalho
2018-08-14 20:10 ` [PATCH v3 00/12] GDB support for more powerpc registers on linux Pedro Franco de Carvalho
2018-08-14 20:41 ` [PATCH v3 02/12] [PowerPC] Don't zero-initialize vector register buffers Pedro Franco de Carvalho
2018-08-14 20:41 ` [PATCH v3 09/12] [PowerPC] Add support for TAR Pedro Franco de Carvalho
2018-08-14 21:13 ` [PATCH v3 10/12] [PowerPC] Add support for EBB and PMU registers Pedro Franco de Carvalho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180814200609.19999-12-pedromfc@linux.ibm.com \
    --to=pedromfc@linux.ibm.com \
    --cc=edjunior@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).