From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH v2 3/8] Add support for non-contiguous blocks to find_pc_partial_function
Date: Tue, 21 Aug 2018 18:09:00 -0000 [thread overview]
Message-ID: <20180821110940.2262c82c@pinnacle.lan> (raw)
In-Reply-To: <9ab90e6a-56af-cb3f-460a-bb2d9384a514@ericsson.com>
On Tue, 21 Aug 2018 11:56:52 -0400
Simon Marchi <simon.marchi@ericsson.com> wrote:
> As I mentioned previously, cache_pc_function_{low,high} could be renamed
> to reflect that they now represent the low/high addresses of the range.
> If you think it's not necessary, it's also fine, but I just want to make
> sure the comment didn't just fall through the cracks.
Once I realized that find_pc_partial_function no longer needed to
track both the minimum/maximum function addresses AND the range in
which PC is found, I decided to leave the name alone. (We only track
the latter now.) For a while, I had rewritten it as you had suggested
in your earlier review. It definitely made sense to do this when
find_pc_partial_function returned values for *ADDRESS and *ENDADDR
which referred to the min/max addresses of the function.
I'll take another look at it though. If I decide to leave these names
unchanged, I'll extend the comment in the declaration for
cache_pc_function_{low,high}.
Kevin
next prev parent reply other threads:[~2018-08-21 18:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 23:50 [PATCH v2 0/8] Non-contiguous address range support Kevin Buettner
2018-08-13 23:59 ` [PATCH v2 1/8] Add block range data structure for blocks with non-contiguous address ranges Kevin Buettner
2018-08-14 0:02 ` [PATCH v2 2/8] Record explicit block ranges from dwarf2read.c Kevin Buettner
2018-08-14 0:04 ` [PATCH v2 3/8] Add support for non-contiguous blocks to find_pc_partial_function Kevin Buettner
2018-08-21 15:57 ` Simon Marchi
2018-08-21 18:09 ` Kevin Buettner [this message]
2018-08-14 0:07 ` [PATCH v2 4/8] Disassemble blocks with non-contiguous ranges Kevin Buettner
2018-08-14 0:09 ` [PATCH v2 5/8] Use BLOCK_ENTRY_PC in place of most uses of BLOCK_START Kevin Buettner
2018-08-14 0:11 ` [PATCH v2 6/8] Introduce find_pc_partial_entry_range and use it in infrun.c Kevin Buettner
2018-08-14 0:12 ` [PATCH v2 7/8] Relocate block range start and end addresses Kevin Buettner
2018-08-14 0:14 ` [PATCH v2 8/8] Test case for functions with non-contiguous ranges Kevin Buettner
2018-08-21 19:25 ` Pedro Alves
2018-08-19 13:35 ` [PATCH v2 0/8] Non-contiguous address range support Simon Marchi
2018-08-20 22:54 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821110940.2262c82c@pinnacle.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).