From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89510 invoked by alias); 21 Aug 2018 18:47:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89488 invoked by uid 89); 21 Aug 2018 18:47:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Aug 2018 18:47:34 +0000 Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF9EC3082E70; Tue, 21 Aug 2018 18:47:33 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-27.phx2.redhat.com [10.3.116.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99B12309128B; Tue, 21 Aug 2018 18:47:33 +0000 (UTC) Date: Tue, 21 Aug 2018 18:47:00 -0000 From: Kevin Buettner To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 6/8] Introduce find_pc_partial_entry_range and use it in infrun.c Message-ID: <20180821114732.4791d981@pinnacle.lan> In-Reply-To: References: <20180820152512.671a7dc7@pinnacle.lan> <20180820154546.5a9f9c6f@pinnacle.lan> <20180821104957.22621602@pinnacle.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00508.txt.bz2 On Tue, 21 Aug 2018 14:23:36 -0400 Simon Marchi wrote: > On 2018-08-21 13:49, Kevin Buettner wrote: > > With regard to "find_pc_partial_entry_range", it seems to me that > > "find_pc_partial_function_entry_range" is overly long. Maybe > > "find_pc_function_entry_range" is better? > > Either way is fine with me. In the end I'd like to rename everything in > the form "find_X_from_Y", which in this case could be > "find_function_entry_range_from_pc". If you like it we can use that, > although it would make it inconsistent with what we have at the moment. I like find_function_entry_range_from_pc. I'll use that. Hopefully, at some point, it will no longer be inconsistent... Thanks, Kevin