From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-150088-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 74242 invoked by alias); 26 Aug 2018 17:41:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 74232 invoked by uid 89); 26 Aug 2018 17:41:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:U*john, H*F:D*au
X-HELO: jocasta.intra
Received: from de.cellform.com (HELO jocasta.intra) (88.217.224.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 26 Aug 2018 17:41:31 +0000
Received: from jocasta.intra (localhost [127.0.0.1])	by jocasta.intra (8.15.2/8.15.2/Debian-8) with ESMTPS id w7QHfRlO019964	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);	Sun, 26 Aug 2018 19:41:27 +0200
Received: (from john@localhost)	by jocasta.intra (8.15.2/8.15.2/Submit) id w7QHfR7N019963;	Sun, 26 Aug 2018 19:41:27 +0200
Date: Sun, 26 Aug 2018 17:41:00 -0000
From: John Darrington <john@darrington.wattle.id.au>
To: Simon Marchi <simark@simark.ca>
Cc: John Darrington <john@darrington.wattle.id.au>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] GDB: New target s12z
Message-ID: <20180826174127.g2qht4j3tqtpxfmz@jocasta.intra>
References: <20180823173526.26144-1-john@darrington.wattle.id.au> <20180823173526.26144-3-john@darrington.wattle.id.au> <ff6eb511-af2c-b9a9-2b7e-722079148704@simark.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ff6eb511-af2c-b9a9-2b7e-722079148704@simark.ca>
User-Agent: NeoMutt/20170113 (1.7.2)
X-SW-Source: 2018-08/txt/msg00637.txt.bz2

Hi Simon,

Thanks for the review.

On Sun, Aug 26, 2018 at 01:19:29PM -0400, Simon Marchi wrote:
     Hi John,
     
     I did a first pass review and noted a few minor nits.  I didn't get too deep in the
     frame_id/unwind code because I'm not too familiar with that.

Pity.  I was hoping someone could help me there :{P

Many of your comments and questions stem from the code which I used as a
pattern, so I'm unsure of the answers.  But I will find out as best I
can and prepare a new patch within the next few days.

J'