Re: [PATCH] Allow remote debugging over a local domain socket

[John Darrington <john@darrington.wattle.id.au>]

On Fri, Aug 31, 2018 at 09:09:23AM -0600, Tom Tromey wrote:
     >>>>> "John" == John Darrington <john@darrington.wattle.id.au> writes:
     
     John> Extend the "target remote"  and "target extended-remote" commands
     John> such that if the filename provided is a unix domain (AF_UNIX)
     John> socket, then it'll be treated as such, instead of trying to open
     John> it as if it were a character device.
     
     Thanks for the patch.
     This looks essentially reasonable to me.
Thanks
     
     John> +/* Open a AF_UNIX socket.  */
     John> +int
     John> +socket_open (struct serial *scb, const char *name)
     John> +{
     
     It seems to me that all the functions in this file could be static.
     This might necessitate wrapping many of them in "#ifndef USE_WIN32API"
     to avoid warnings about unused code, but that seems like an improvement
     as well.

OK
     
     John> +int
     John> +ser_socket_send_break (struct serial *scb)
     John> +{
     John> +  /* Send telnet IAC and BREAK characters.  */
     John> +  return (serial_write (scb, "\377\363", 2));
     John> +}
     
     I don't really know what's expected here, but is this correct?

I wondererd about that too.  This bit I copied from the ser-tcp.c file.
     
     John> diff --git a/gdb/ser-socket.h b/gdb/ser-socket.h
     John> new file mode 100644
     John> index 0000000000..58509302d6
     John> --- /dev/null
     John> +++ b/gdb/ser-socket.h
     
     You could just drop this file entirely.
     
OK.

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.