From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 8.2+trunk 0/2] two small rust fixes
Date: Fri, 31 Aug 2018 15:31:00 -0000 [thread overview]
Message-ID: <20180831153147.GB5568@adacore.com> (raw)
In-Reply-To: <20180831145302.14493-1-tom@tromey.com>
Hi Tom,
> This series fixes a couple of small bugs I noticed while testing gdb
> against a version of the Rust compiler that emits DW_TAG_variant_part.
> See https://github.com/rust-lang/rust/issues/32920 for details of that.
>
> While doing this I found a couple of bugs. I'd like to put these on
> the 8.2 branch, because all the DW_TAG_variant_part stuff was slated
> for 8.2 and this gdb release is timely considering when the Rust
> compiler patch will land.
>
> The first patch is obvious and just a test case thinko.
>
> The second patch changes how DW_TAG_variant_part is handled in the
> DWARF reader. I think this is reasonably safe as it is clearly
> targeted at just this tag, which currently is only really supported
> for Rust (Gnat can emit DW_TAG_variant_part with a special flag but
> this is not common and the gdb Ada support for this has not been
> implemented).
>
> Let me know what you think.
No real comment on the first patch, as I don't know rust, but
the second one looks reasonable, for both master and 8.2.
Thanks!
--
Joel
prev parent reply other threads:[~2018-08-31 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 14:53 Tom Tromey
2018-08-31 14:53 ` [PATCH 8.2+trunk 2/2] Set TYPE_LENGTH on a variant part Tom Tromey
2018-08-31 14:53 ` [PATCH 8.2+trunk 1/2] Fix a small bug in gdb.rust/simple.rs Tom Tromey
2018-08-31 15:31 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831153147.GB5568@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).