From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97413 invoked by alias); 31 Aug 2018 15:31:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97399 invoked by uid 89); 31 Aug 2018 15:31:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 15:31:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C23731173FB; Fri, 31 Aug 2018 11:31:49 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8Vgi7NJ2NeLW; Fri, 31 Aug 2018 11:31:49 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8F0111173C9; Fri, 31 Aug 2018 11:31:49 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8F8F686A7A; Fri, 31 Aug 2018 17:31:47 +0200 (CEST) Date: Fri, 31 Aug 2018 15:31:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 8.2+trunk 0/2] two small rust fixes Message-ID: <20180831153147.GB5568@adacore.com> References: <20180831145302.14493-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180831145302.14493-1-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-08/txt/msg00868.txt.bz2 Hi Tom, > This series fixes a couple of small bugs I noticed while testing gdb > against a version of the Rust compiler that emits DW_TAG_variant_part. > See https://github.com/rust-lang/rust/issues/32920 for details of that. > > While doing this I found a couple of bugs. I'd like to put these on > the 8.2 branch, because all the DW_TAG_variant_part stuff was slated > for 8.2 and this gdb release is timely considering when the Rust > compiler patch will land. > > The first patch is obvious and just a test case thinko. > > The second patch changes how DW_TAG_variant_part is handled in the > DWARF reader. I think this is reasonably safe as it is clearly > targeted at just this tag, which currently is only really supported > for Rust (Gnat can emit DW_TAG_variant_part with a special flag but > this is not common and the gdb Ada support for this has not been > implemented). > > Let me know what you think. No real comment on the first patch, as I don't know rust, but the second one looks reasonable, for both master and 8.2. Thanks! -- Joel