From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 3/4] Simplify ada-exp.o rule
Date: Mon, 03 Sep 2018 19:04:00 -0000 [thread overview]
Message-ID: <20180903190359.12817-4-tom@tromey.com> (raw)
In-Reply-To: <20180903190359.12817-1-tom@tromey.com>
The ada-exp.o rule no longer needs to pass -Wno-old-style-definition
to the compiler, as this option has no meaning in C++. So, This patch
simplifies the explicit ada-exp.o rule in the Makefile. The rule is
still needed because, according to the comment, ada-exp.c may appear
in the srcdir.
gdb/ChangeLog
2018-09-03 Tom Tromey <tom@tromey.com>
* Makefile.in (GDB_WARN_CFLAGS_NO_DEFS): Remove.
(ada-exp.o): Update.
---
gdb/ChangeLog | 5 +++++
gdb/Makefile.in | 8 +-------
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 16aac9dadf2..c76a4e4394c 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -199,9 +199,6 @@ WERROR_CFLAGS = @WERROR_CFLAGS@
GDB_WARN_CFLAGS = $(WARN_CFLAGS)
GDB_WERROR_CFLAGS = $(WERROR_CFLAGS)
-GDB_WARN_CFLAGS_NO_DEFS = `echo " $(GDB_WARN_CFLAGS) " \
- | sed "s/ -Wold-style-definition / -Wno-old-style-definition /g"`
-
RDYNAMIC = @RDYNAMIC@
# Where is the INTL library? Typically in ../intl.
@@ -2385,11 +2382,8 @@ ALLDEPFILES = \
# development builds.
ADA_EXP_C = `if test -f ada-exp.c; then echo ada-exp.c; else echo $(srcdir)/ada-exp.c; fi`
-# Some versions of flex give output that triggers
-# -Wold-style-definition.
ada-exp.o: ada-exp.c
- $(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) \
- $(GDB_WARN_CFLAGS_NO_DEFS) $(COMPILE.post) $(ADA_EXP_C)
+ $(COMPILE) $(ADA_EXP_C)
$(POSTCOMPILE)
# Message files. Based on code in gcc/Makefile.in.
--
2.13.6
next prev parent reply other threads:[~2018-09-03 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 19:04 [PATCH 0/4] Minor gdb build fixes Tom Tromey
2018-09-03 19:04 ` [PATCH 4/4] Remove --enable-multi-ice Tom Tromey
2018-09-03 19:04 ` [PATCH 1/4] Remove obsolete comments from Makefiles Tom Tromey
2018-09-03 19:04 ` [PATCH 2/4] Remove unneeded explicit .o targets Tom Tromey
2018-09-03 19:04 ` Tom Tromey [this message]
2018-09-04 7:58 ` [PATCH 3/4] Simplify ada-exp.o rule Joel Brobecker
2018-09-04 7:55 ` [PATCH 0/4] Minor gdb build fixes Joel Brobecker
2018-09-04 23:43 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903190359.12817-4-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).