From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118653 invoked by alias); 4 Sep 2018 07:58:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118643 invoked by uid 89); 4 Sep 2018 07:58:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Sep 2018 07:58:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B923A56AB6; Tue, 4 Sep 2018 03:58:51 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HFjLoeqyQlMX; Tue, 4 Sep 2018 03:58:51 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 899B056A90; Tue, 4 Sep 2018 03:58:51 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 185DC86A82; Tue, 4 Sep 2018 09:58:50 +0200 (CEST) Date: Tue, 04 Sep 2018 07:58:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Simplify ada-exp.o rule Message-ID: <20180904075850.GB2495@adacore.com> References: <20180903190359.12817-1-tom@tromey.com> <20180903190359.12817-4-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180903190359.12817-4-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-09/txt/msg00044.txt.bz2 > The ada-exp.o rule no longer needs to pass -Wno-old-style-definition > to the compiler, as this option has no meaning in C++. So, This patch > simplifies the explicit ada-exp.o rule in the Makefile. The rule is > still needed because, according to the comment, ada-exp.c may appear > in the srcdir. For the record, this is correct; in particular, the source packages we produce (nightly and releases) include them. I believe this helps avoid a dependency on bison (and flex for ada-lex.[lc]) for users building from source packages rather than from git sources. -- Joel