New ARI warning Tue Sep 4 01:56:28 UTC 2018

New ARI warning Tue Sep 4 01:56:28 UTC 2018

[GDB Administrator]

474a475
> gdb/riscv-tdep.c:2560: code: OP eol: Do not use &&, or || at the end of a line
gdb/riscv-tdep.c:2560:    = (get_frame_register_signed (this_frame, cache->frame_base_reg) +

Re: New ARI warning Tue Sep 4 01:56:28 UTC 2018

[Andrew Burgess]

* GDB Administrator <gdbadmin@sourceware.org> [2018-09-04 01:56:28 +0000]:

> 474a475
> > gdb/riscv-tdep.c:2560: code: OP eol: Do not use &&, or || at the end of a line
> gdb/riscv-tdep.c:2560:    = (get_frame_register_signed (this_frame, cache->frame_base_reg) +

Sorry for that.

Pushed the patch below to fix this issue.

Thanks,
Andrew

---

gdb/riscv: Fix an ARI warning

This patch fixes an ARI violation in riscv-tdep.c (line ends with
'+').

gdb/ChangeLog:

	* riscv-tdep.c (riscv_frame_cache): Fix ARI warning, don't end a
	line with '+'.
---
 gdb/ChangeLog    | 5 +++++
 gdb/riscv-tdep.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
index b2247b59f6f..254914c9c7e 100644
--- a/gdb/riscv-tdep.c
+++ b/gdb/riscv-tdep.c
@@ -2557,8 +2557,8 @@ riscv_frame_cache (struct frame_info *this_frame, void **this_cache)
 
   /* We can now calculate the frame base address.  */
   cache->frame_base
-    = (get_frame_register_signed (this_frame, cache->frame_base_reg) +
-       cache->frame_base_offset);
+    = (get_frame_register_signed (this_frame, cache->frame_base_reg)
+       + cache->frame_base_offset);
   if (riscv_debug_unwinder)
     fprintf_unfiltered (gdb_stdlog, "Frame base is %s ($%s + 0x%x)\n",
                         core_addr_to_string (cache->frame_base),
-- 
2.14.4