From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100097 invoked by alias); 4 Sep 2018 23:26:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100088 invoked by uid 89); 4 Sep 2018 23:26:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bl, Hx-languages-length:1036 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Sep 2018 23:26:53 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E6E13C0587D1; Tue, 4 Sep 2018 23:26:51 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-195.phx2.redhat.com [10.3.116.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BBAF460851; Tue, 4 Sep 2018 23:26:51 +0000 (UTC) Date: Tue, 04 Sep 2018 23:26:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: ysimhony@gmail.com Subject: Re: src/gdb/breakpoint.c:3092: redundant test ? Message-ID: <20180904162650.722ebe92@pinnacle.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00063.txt.bz2 On Thu, 30 Aug 2018 21:34:45 +0300 wrote: > 2018-08-30 Yacov Simhony > > * breakpoint.c (update_inserted_breakpoint_locations): remove reduandant > condition typo - s/reduandant/redundant/ Also, place a period at the end of that ChangeLog entry and make sure it's correctly indented when you put it in the ChangeLog. > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 4e7dac5..3a9b712 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -2898,7 +2898,7 @@ update_inserted_breakpoint_locations (void) > /* We only want to update locations that are already inserted > and need updating. This is to avoid unwanted insertion during > deletion of breakpoints. */ > - if (!bl->inserted || (bl->inserted && !bl->needs_update)) > + if (!bl->inserted || !bl->needs_update) > continue; > > switch_to_program_space_and_thread (bl->pspace); This looks correct to me. This is okay to push with the ChangeLog fixes noted above. Kevin