* src/gdb/breakpoint.c:3092: redundant test ?
@ 2018-08-30 18:34 יעקב שמחוני
2018-09-04 23:26 ` Kevin Buettner
0 siblings, 1 reply; 3+ messages in thread
From: יעקב שמחוני @ 2018-08-30 18:34 UTC (permalink / raw)
To: gdb-patches
2018-08-30 Yacov Simhony <ysimhony@gmail.com>
* breakpoint.c (update_inserted_breakpoint_locations): remove reduandant
condition
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 4e7dac5..3a9b712 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -2898,7 +2898,7 @@ update_inserted_breakpoint_locations (void)
/* We only want to update locations that are already inserted
and need updating. This is to avoid unwanted insertion during
deletion of breakpoints. */
- if (!bl->inserted || (bl->inserted && !bl->needs_update))
+ if (!bl->inserted || !bl->needs_update)
continue;
switch_to_program_space_and_thread (bl->pspace);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: src/gdb/breakpoint.c:3092: redundant test ?
2018-08-30 18:34 src/gdb/breakpoint.c:3092: redundant test ? יעקב שמחוני
@ 2018-09-04 23:26 ` Kevin Buettner
2018-09-18 14:02 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2018-09-04 23:26 UTC (permalink / raw)
To: gdb-patches; +Cc: ysimhony
On Thu, 30 Aug 2018 21:34:45 +0300
<ysimhony@gmail.com> wrote:
> 2018-08-30 Yacov Simhony <ysimhony@gmail.com>
>
> * breakpoint.c (update_inserted_breakpoint_locations): remove reduandant
> condition
typo - s/reduandant/redundant/
Also, place a period at the end of that ChangeLog entry and make sure
it's correctly indented when you put it in the ChangeLog.
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 4e7dac5..3a9b712 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -2898,7 +2898,7 @@ update_inserted_breakpoint_locations (void)
> /* We only want to update locations that are already inserted
> and need updating. This is to avoid unwanted insertion during
> deletion of breakpoints. */
> - if (!bl->inserted || (bl->inserted && !bl->needs_update))
> + if (!bl->inserted || !bl->needs_update)
> continue;
>
> switch_to_program_space_and_thread (bl->pspace);
This looks correct to me.
This is okay to push with the ChangeLog fixes noted above.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: src/gdb/breakpoint.c:3092: redundant test ?
2018-09-04 23:26 ` Kevin Buettner
@ 2018-09-18 14:02 ` Tom Tromey
0 siblings, 0 replies; 3+ messages in thread
From: Tom Tromey @ 2018-09-18 14:02 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches, ysimhony
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
Kevin> This is okay to push with the ChangeLog fixes noted above.
I think Yacov probably does not have write access.
Yacov, if you can send a patch addressing the review comments, I can
check it in for you.
thanks,
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-18 14:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-30 18:34 src/gdb/breakpoint.c:3092: redundant test ? יעקב שמחוני
2018-09-04 23:26 ` Kevin Buettner
2018-09-18 14:02 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).