From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/5] Use KF_PATH to verify the size of a struct kinfo_file.
Date: Sat, 08 Sep 2018 00:38:00 -0000 [thread overview]
Message-ID: <20180908003659.37482-2-jhb@FreeBSD.org> (raw)
In-Reply-To: <20180908003659.37482-1-jhb@FreeBSD.org>
fbsd_core_vnode_path needs to use the offset of the kf_path member of
struct kinfo_file as the minimum size of a struct kinfo_file object.
However, it was using KVE_PATH instead due to a copy and paste bug.
gdb/ChangeLog:
* fbsd-tdep.c (fbsd_core_vnode_path): Use KF_PATH instead of
KVE_PATH.
---
gdb/ChangeLog | 5 +++++
gdb/fbsd-tdep.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e6f44a3ac2..d32b390778 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-09-07 John Baldwin <jhb@FreeBSD.org>
+
+ * fbsd-tdep.c (fbsd_core_vnode_path): Use KF_PATH instead of
+ KVE_PATH.
+
2018-09-06 Simon Ser <contact@emersion.fr>
PR gdb/23105
diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c
index ed43087169..9e6d7276c4 100644
--- a/gdb/fbsd-tdep.c
+++ b/gdb/fbsd-tdep.c
@@ -781,12 +781,12 @@ fbsd_core_vnode_path (struct gdbarch *gdbarch, int fd)
/* Skip over the structure size. */
descdata += 4;
- while (descdata + KVE_PATH < descend)
+ while (descdata + KF_PATH < descend)
{
ULONGEST structsize;
structsize = bfd_get_32 (core_bfd, descdata + KF_STRUCTSIZE);
- if (structsize < KVE_PATH)
+ if (structsize < KF_PATH)
error (_("malformed core note - vmmap entry too small"));
if (bfd_get_32 (core_bfd, descdata + KF_TYPE) == KINFO_FILE_TYPE_VNODE
--
2.18.0
next prev parent reply other threads:[~2018-09-08 0:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 0:38 [PATCH 0/5] Add a new 'info proc files' command John Baldwin
2018-09-08 0:38 ` [PATCH 2/5] Add a new 'info proc files' subcommand of 'info proc' John Baldwin
2018-09-08 6:49 ` Eli Zaretskii
2018-09-08 22:31 ` Simon Marchi
2018-09-09 5:23 ` Eli Zaretskii
2018-09-10 18:43 ` John Baldwin
2018-09-10 19:11 ` Eli Zaretskii
2018-09-08 22:32 ` Simon Marchi
2018-09-08 0:38 ` [PATCH 3/5] Add support for 'info proc files' on FreeBSD core dumps John Baldwin
2018-09-08 22:54 ` Simon Marchi
2018-09-10 19:37 ` John Baldwin
2018-09-13 15:08 ` Tom Tromey
2018-09-13 18:42 ` John Baldwin
2018-09-08 0:38 ` John Baldwin [this message]
2018-09-08 22:25 ` [PATCH 1/5] Use KF_PATH to verify the size of a struct kinfo_file Simon Marchi
2018-09-08 0:46 ` [PATCH 4/5] Support 'info proc files' on live FreeBSD processes John Baldwin
2018-09-08 23:01 ` Simon Marchi
2018-09-10 18:30 ` John Baldwin
2018-09-10 19:03 ` Simon Marchi
2018-09-12 22:38 ` John Baldwin
2018-09-08 0:46 ` [PATCH 5/5] Document the 'info proc files' command John Baldwin
2018-09-08 7:01 ` Eli Zaretskii
2018-09-10 18:43 ` John Baldwin
2018-09-10 19:13 ` Eli Zaretskii
2018-09-10 18:52 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180908003659.37482-2-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).