From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Disallow the return of borrowed references
Date: Thu, 13 Sep 2018 05:30:00 -0000 [thread overview]
Message-ID: <20180913053007.11780-1-tom@tromey.com> (raw)
While working on a different Python patch, I misread
pspace_to_pspace_object and thought it was not handling reference
counts properly.
It is -- but I found it difficult to reason about because it returns a
borrowed reference, but uses gdbpy_ref as well.
This series changes gdb so that none of the Python functions will
return a borrowed reference. These functions are modified instead to
return a new reference using gdbpy_ref<>, which not only makes the
intent clear, but also makes it more difficult to have a buggy caller.
This could go further and make all functions return gdbpy_ref<>.
(Even Python-facing ones could be done via template fuction wrappers.)
However I have not done this.
I think now gdb should disallow Python functions returning borrowed
references. Accepting a borrowed reference is still ok, and I think
should continue to be.
I think this series found at least one bug:
infpy_thread_from_thread_handle could return None without incref'ing
it.
Let me know what you think. I tested this on x86-64 Fedora 28.
Tom
next reply other threads:[~2018-09-13 5:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 5:30 Tom Tromey [this message]
2018-09-13 5:30 ` [PATCH 4/4] Remove CPYCHECKER_RETURNS_BORROWED_REF Tom Tromey
2018-09-13 5:30 ` [PATCH 2/4] Change objfile_to_objfile_object to return a new reference Tom Tromey
2018-09-16 1:28 ` Simon Marchi
2018-09-16 2:00 ` Simon Marchi
2018-09-13 5:30 ` [PATCH 1/4] Change pspace_to_pspace_object " Tom Tromey
2018-09-16 0:57 ` Simon Marchi
2018-09-16 12:59 ` Tom Tromey
2018-09-16 1:19 ` Simon Marchi
2018-09-16 1:58 ` Simon Marchi
2018-09-16 13:01 ` Tom Tromey
2018-09-13 5:30 ` [PATCH 3/4] Change thread_to_thread_object " Tom Tromey
2018-09-16 2:11 ` Simon Marchi
2018-09-16 13:32 ` Tom Tromey
2018-09-16 14:05 ` Tom Tromey
2018-09-16 15:35 ` Tom Tromey
2018-09-17 0:52 ` Simon Marchi
2018-09-17 5:31 ` Tom Tromey
2018-09-16 0:56 ` [PATCH 0/4] Disallow the return of borrowed references Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913053007.11780-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).