From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 4/4] Remove CPYCHECKER_RETURNS_BORROWED_REF
Date: Thu, 13 Sep 2018 05:30:00 -0000 [thread overview]
Message-ID: <20180913053007.11780-5-tom@tromey.com> (raw)
In-Reply-To: <20180913053007.11780-1-tom@tromey.com>
CPYCHECKER_RETURNS_BORROWED_REF is not used, and I think should never
be used. This patch removes it.
gdb/ChangeLog
2018-09-12 Tom Tromey <tom@tromey.com>
* python/python-internal.h (CPYCHECKER_RETURNS_BORROWED_REF):
Remove.
---
gdb/ChangeLog | 5 +++++
gdb/python/python-internal.h | 11 +++--------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h
index dc8d7cdd32a..59e20238856 100644
--- a/gdb/python/python-internal.h
+++ b/gdb/python/python-internal.h
@@ -27,14 +27,9 @@
comes with the Python plugin for GCC. See:
https://gcc-python-plugin.readthedocs.org/en/latest/cpychecker.html
The checker defines a WITH_ macro for each attribute it
- exposes. */
-
-#ifdef WITH_CPYCHECKER_RETURNS_BORROWED_REF_ATTRIBUTE
-#define CPYCHECKER_RETURNS_BORROWED_REF \
- __attribute__ ((cpychecker_returns_borrowed_ref))
-#else
-#define CPYCHECKER_RETURNS_BORROWED_REF
-#endif
+ exposes. Note that we intentionally do not use
+ 'cpychecker_returns_borrowed_ref' -- that idiom is forbidden in
+ gdb. */
#ifdef WITH_CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF_ATTRIBUTE
#define CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF(ARG) \
--
2.17.1
next prev parent reply other threads:[~2018-09-13 5:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 5:30 [PATCH 0/4] Disallow the return of borrowed references Tom Tromey
2018-09-13 5:30 ` [PATCH 2/4] Change objfile_to_objfile_object to return a new reference Tom Tromey
2018-09-16 1:28 ` Simon Marchi
2018-09-16 2:00 ` Simon Marchi
2018-09-13 5:30 ` Tom Tromey [this message]
2018-09-13 5:30 ` [PATCH 1/4] Change pspace_to_pspace_object " Tom Tromey
2018-09-16 0:57 ` Simon Marchi
2018-09-16 12:59 ` Tom Tromey
2018-09-16 1:19 ` Simon Marchi
2018-09-16 1:58 ` Simon Marchi
2018-09-16 13:01 ` Tom Tromey
2018-09-13 5:30 ` [PATCH 3/4] Change thread_to_thread_object " Tom Tromey
2018-09-16 2:11 ` Simon Marchi
2018-09-16 13:32 ` Tom Tromey
2018-09-16 14:05 ` Tom Tromey
2018-09-16 15:35 ` Tom Tromey
2018-09-17 0:52 ` Simon Marchi
2018-09-17 5:31 ` Tom Tromey
2018-09-16 0:56 ` [PATCH 0/4] Disallow the return of borrowed references Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913053007.11780-5-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).