From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37395 invoked by alias); 17 Sep 2018 18:18:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37386 invoked by uid 89); 17 Sep 2018 18:18:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=meanwhile X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 18:18:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 72022117D58; Mon, 17 Sep 2018 14:18:05 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id D89SXudD4yCF; Mon, 17 Sep 2018 14:18:05 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 372A4117DB0; Mon, 17 Sep 2018 14:18:05 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 6CFD9873D9; Mon, 17 Sep 2018 11:18:03 -0700 (PDT) Date: Mon, 17 Sep 2018 18:18:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Check for gmp when checking for mpfr Message-ID: <20180917181803.GC19172@adacore.com> References: <20180916184502.19617-1-tom@tromey.com> <20180916184502.19617-2-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180916184502.19617-2-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-09/txt/msg00592.txt.bz2 Hi Tom, On Sun, Sep 16, 2018 at 12:45:01PM -0600, Tom Tromey wrote: > There was a report on irc that the gdb check for mpfr failed when only > static libraries are available. The issue is that mpfr depends on > gmp, but this is not handled explicitly by gdb. > > Ideally upstream would switch to pkg-config. Or even more ideally, we > would incorporate pkg-config into the compiler and not mess with any > of this. > > Meanwhile, this changes gdb's configure to add gmp to the link line > when checking for mpfr. > > ChangeLog > 2018-09-16 Tom Tromey > > * configure: Rebuild. > * configure.ac: Use gmp as a library dependency when checking for > mpfr. Thanks for the patch. This looks good to me. -- Joel