From: Joel Brobecker <brobecker@adacore.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle 64-bit Solaris/x86 ld.so.1
Date: Mon, 17 Sep 2018 18:37:00 -0000 [thread overview]
Message-ID: <20180917183723.GF19172@adacore.com> (raw)
In-Reply-To: <yddh8ionqwz.fsf@CeBiTec.Uni-Bielefeld.DE>
Hello Rainer,
> 2018-06-27 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> * solib-svr4.c (svr4_same_1): Also handle amd64 ld.so.1.
Looks good to me. OK to push, but trying to have the correct
author in the ChangeLog file.
> # HG changeset patch
> # Parent 24bcd64cb0c1824acde40384274e58fa9bf13438
> Handle 64-bit Solaris/x86 ld.so.1
>
> diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
> --- a/gdb/solib-svr4.c
> +++ b/gdb/solib-svr4.c
> @@ -153,8 +153,12 @@ svr4_same_1 (const char *gdb_so_name, co
> && strcmp (inferior_so_name, "/lib/ld.so.1") == 0)
> return 1;
>
> - /* Similarly, we observed the same issue with sparc64, but with
> + /* Similarly, we observed the same issue with amd64 and sparcv9, but with
> different locations. */
> + if (strcmp (gdb_so_name, "/usr/lib/amd64/ld.so.1") == 0
> + && strcmp (inferior_so_name, "/lib/amd64/ld.so.1") == 0)
> + return 1;
> +
> if (strcmp (gdb_so_name, "/usr/lib/sparcv9/ld.so.1") == 0
> && strcmp (inferior_so_name, "/lib/sparcv9/ld.so.1") == 0)
> return 1;
--
Joel
next prev parent reply other threads:[~2018-09-17 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 14:24 Rainer Orth
2018-09-17 18:37 ` Joel Brobecker [this message]
2018-09-19 9:11 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917183723.GF19172@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).