From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60553 invoked by alias); 17 Sep 2018 18:37:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60535 invoked by uid 89); 17 Sep 2018 18:37:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1069 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 18:37:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 366BF117E62; Mon, 17 Sep 2018 14:37:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PrxqPBTNppeu; Mon, 17 Sep 2018 14:37:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 051D91175E6; Mon, 17 Sep 2018 14:37:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 56799873D9; Mon, 17 Sep 2018 11:37:23 -0700 (PDT) Date: Mon, 17 Sep 2018 18:37:00 -0000 From: Joel Brobecker To: Rainer Orth Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Handle 64-bit Solaris/x86 ld.so.1 Message-ID: <20180917183723.GF19172@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-09/txt/msg00597.txt.bz2 Hello Rainer, > 2018-06-27 Rainer Orth > > * solib-svr4.c (svr4_same_1): Also handle amd64 ld.so.1. Looks good to me. OK to push, but trying to have the correct author in the ChangeLog file. > # HG changeset patch > # Parent 24bcd64cb0c1824acde40384274e58fa9bf13438 > Handle 64-bit Solaris/x86 ld.so.1 > > diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c > --- a/gdb/solib-svr4.c > +++ b/gdb/solib-svr4.c > @@ -153,8 +153,12 @@ svr4_same_1 (const char *gdb_so_name, co > && strcmp (inferior_so_name, "/lib/ld.so.1") == 0) > return 1; > > - /* Similarly, we observed the same issue with sparc64, but with > + /* Similarly, we observed the same issue with amd64 and sparcv9, but with > different locations. */ > + if (strcmp (gdb_so_name, "/usr/lib/amd64/ld.so.1") == 0 > + && strcmp (inferior_so_name, "/lib/amd64/ld.so.1") == 0) > + return 1; > + > if (strcmp (gdb_so_name, "/usr/lib/sparcv9/ld.so.1") == 0 > && strcmp (inferior_so_name, "/lib/sparcv9/ld.so.1") == 0) > return 1; -- Joel