From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode
Date: Mon, 17 Sep 2018 21:21:00 -0000 [thread overview]
Message-ID: <20180917212135.GH19172@adacore.com> (raw)
In-Reply-To: <87r2hrnbox.fsf@tromey.com>
> >>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
> Joel> Are we missing a '$' before tentative_python_cflags in the string,
> Joel> by any chance?
>
> Tom> Yes, oops. I wonder how that slipped through.
>
> Obviously I did not test in release mode.
> I've fixed the bug and tried it both ways.
Thanks Tom. Other than this comment, I had no other comment so,
now that it is fixed and tested, I think you can push.
--
Joel
next prev parent reply other threads:[~2018-09-17 21:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 18:45 [PATCH 0/2] two small configure patches Tom Tromey
2018-09-16 18:46 ` [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode Tom Tromey
2018-09-17 18:19 ` Joel Brobecker
2018-09-17 18:22 ` Tom Tromey
2018-09-17 19:53 ` Tom Tromey
2018-09-17 21:21 ` Joel Brobecker [this message]
2018-09-17 21:22 ` Tom Tromey
2018-09-16 18:46 ` [PATCH 1/2] Check for gmp when checking for mpfr Tom Tromey
2018-09-17 18:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917212135.GH19172@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).