From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130233 invoked by alias); 17 Sep 2018 21:21:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130224 invoked by uid 89); 17 Sep 2018 21:21:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 21:21:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 622BC1170C6; Mon, 17 Sep 2018 17:21:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vQ1V5p7Ig-yI; Mon, 17 Sep 2018 17:21:37 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 32A13116533; Mon, 17 Sep 2018 17:21:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8270E873D9; Mon, 17 Sep 2018 14:21:35 -0700 (PDT) Date: Mon, 17 Sep 2018 21:21:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode Message-ID: <20180917212135.GH19172@adacore.com> References: <20180916184502.19617-1-tom@tromey.com> <20180916184502.19617-3-tom@tromey.com> <20180917181905.GD19172@adacore.com> <87va74ugpf.fsf@tromey.com> <87r2hrnbox.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r2hrnbox.fsf@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-09/txt/msg00606.txt.bz2 > >>>>> "Joel" == Joel Brobecker writes: > Joel> Are we missing a '$' before tentative_python_cflags in the string, > Joel> by any chance? > > Tom> Yes, oops. I wonder how that slipped through. > > Obviously I did not test in release mode. > I've fixed the bug and tried it both ways. Thanks Tom. Other than this comment, I had no other comment so, now that it is fixed and tested, I think you can push. -- Joel