From: Joel Brobecker <brobecker@adacore.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Provide pid_to_exec_file on Solaris (PR tdep/17903)
Date: Wed, 19 Sep 2018 18:06:00 -0000 [thread overview]
Message-ID: <20180919180630.GS19172@adacore.com> (raw)
In-Reply-To: <yddo9ctgz6i.fsf@CeBiTec.Uni-Bielefeld.DE>
> >> PR tdep/17903
> >> * procfs.c (procfs_target): Declare pid_to_exec_file.
> >> (procfs_target::pid_to_exec_file): New.
> >
> > Nice :). This is OK for me as is; one question: Have you considered
> > the use of an std::string for the variable "name"? I thought about it,
> > and I'm not sure it would make the code all that better, but thought
> > I'd mention it again, in case you or someone else sees something
> > I don't see.
>
> TBH, I know close to nothing about C++, so rely on others for
> suggestions here.
In that case, I would go with what you have now considering the current
interface for this method, and possibly enhance it later as a followup.
It's not obvious to me that switching that part to C++ is a win.
--
Joel
next prev parent reply other threads:[~2018-09-19 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:19 Rainer Orth
2018-09-19 14:36 ` Joel Brobecker
2018-09-19 17:44 ` Rainer Orth
2018-09-19 18:06 ` Joel Brobecker [this message]
2018-09-19 14:49 ` Tom Tromey
2018-09-19 14:53 ` Simon Marchi
2018-09-19 17:50 ` Rainer Orth
2018-09-19 17:47 ` Rainer Orth
2018-09-20 9:27 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919180630.GS19172@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).