From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96381 invoked by alias); 3 Oct 2018 22:28:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96363 invoked by uid 89); 3 Oct 2018 22:28:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=cleans X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 22:28:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7BB035607E; Wed, 3 Oct 2018 18:28:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2z7ZoJilgWbg; Wed, 3 Oct 2018 18:28:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3F9EA5607B; Wed, 3 Oct 2018 18:28:53 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8C9C782C67; Wed, 3 Oct 2018 15:28:51 -0700 (PDT) Date: Wed, 03 Oct 2018 22:28:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Simplify complaints and symbol-reading output Message-ID: <20181003222851.GC2477@adacore.com> References: <20180923150957.5798-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180923150957.5798-1-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-10/txt/msg00098.txt.bz2 Hi Tom, On Sun, Sep 23, 2018 at 09:09:50AM -0600, Tom Tromey wrote: > This series cleans up symbol-reading output and simplifies complaints > a bit more. I've long thought the current output was difficult to > read, and in some cases actively confusing; this series is another > attempt to fix this up. (The previous attempt involved adding > progress metering.) I read through the series; I don't really have a strong opinion, but overall, the updated code and output both look better to me (simplified code, clearer output). The patch looks good to me. -- Joel