From: Joel Brobecker <brobecker@adacore.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Tom Tromey <tom@tromey.com>, Pedro Alves <palves@redhat.com>,
Simon Marchi <simon.marchi@ericsson.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/8] Add -Wshadow=local
Date: Fri, 05 Oct 2018 11:14:00 -0000 [thread overview]
Message-ID: <20181005111453.GD2477@adacore.com> (raw)
In-Reply-To: <yddsh1kyd7w.fsf@CeBiTec.Uni-Bielefeld.DE>
> this patch series broke the Solaris builds:
>
> ../../binutils-gdb/gdb/sol-thread.c: In member function ‘virtual ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)’:
> ../../binutils-gdb/gdb/sol-thread.c:443:14: error: declaration of ‘save_ptid’ shadows a previous local [-Werror=shadow=compatible-local]
> ptid_t save_ptid = ptid;
> ^~~~~~~~~
> ../../binutils-gdb/gdb/sol-thread.c:432:10: note: shadowed declaration is here
> ptid_t save_ptid;
> ^~~~~~~~~
Looking at the code, that's one location where I think the warning
is pretty nice; while it might not flag in the code, I think the code
itself could be clearer if we used two different variable names.
What's your take on this? Do you think it would make sense? And
would you be able to make that change; as far as I can tell, if
I were to attempt the change myself, I would probably change the name
of the first one to something like save_inferior_ptid, or something
like that.
Thanks!
--
Joel
next prev parent reply other threads:[~2018-10-05 11:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 4:08 Tom Tromey
2018-09-23 4:08 ` [PATCH 7/8] Shadowing fix in gdbscm_frame_read_var Tom Tromey
2018-10-03 16:12 ` Simon Marchi
2018-10-04 12:44 ` Tom Tromey
2018-09-23 4:08 ` [PATCH 8/8] Add -Wshadow=local Tom Tromey
2018-09-23 4:08 ` [PATCH 2/8] Avoid shadowing in gdbserver Tom Tromey
2018-10-12 4:19 ` Kevin Buettner
2018-09-23 4:08 ` [PATCH 3/8] Use std::string in mdebugread.c Tom Tromey
2018-10-12 4:27 ` Kevin Buettner
2018-09-23 4:08 ` [PATCH 4/8] Avoid shadowing in linux-tdep.c Tom Tromey
2018-10-12 4:50 ` Kevin Buettner
2018-09-23 4:08 ` [PATCH 5/8] Fix latent bug in msp430-tdep.c Tom Tromey
2018-10-12 4:10 ` Kevin Buettner
2018-09-23 4:08 ` [PATCH 6/8] Avoid shadowing in fdwalk Tom Tromey
2018-10-12 4:54 ` Kevin Buettner
2018-09-23 4:09 ` [PATCH 1/8] Simple -Wshadow=local fixes Tom Tromey
2018-10-03 16:01 ` Simon Marchi
2018-10-04 3:36 ` Simon Marchi
2018-10-04 12:22 ` Simon Marchi
2018-10-04 12:43 ` Tom Tromey
2018-10-03 15:02 ` [PATCH 0/8] Add -Wshadow=local Simon Marchi
2018-10-03 16:16 ` Simon Marchi
2018-10-03 16:34 ` Pedro Alves
2018-10-03 17:53 ` Joel Brobecker
2018-10-05 4:57 ` Tom Tromey
2018-10-05 9:06 ` Rainer Orth
2018-10-05 11:14 ` Joel Brobecker [this message]
2018-10-05 13:37 ` [SPAM] " Tom Tromey
2018-10-05 15:58 ` Rainer Orth
2018-10-12 5:25 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005111453.GD2477@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).