From: Gary Benson <gbenson@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp
Date: Tue, 09 Oct 2018 13:52:00 -0000 [thread overview]
Message-ID: <20181009135155.GB12668@blade.nx> (raw)
In-Reply-To: <20181005101122.GA23867@delia>
Tom de Vries wrote:
> append FLAGS " \"$binfile\""
> append FLAGS " -batch"
> + append FLAGS " -ex \"target native\""
> append FLAGS " -ex \"catch exec\""
> append FLAGS " -ex \"set follow-exec-mode new\""
I'm a little confused with this part, doesn't this force the test to
run on the host?
> + # We're not testing the "status returned by the spawned process",
> + # because it's currently one, and we suspect it will be zero after
> + # fixing PR23368 - "gdb goes to into background when hitting exec
> + # catchpoint with follow-exec-mode new"
> + #gdb_assert { [lindex $result 3] == 0 }
I'm not sure we should commit commented-out code. Why not have the
test assert { [lindex $result 3] == 1 } if that's what's happening
now, with the comment reworded to indicate that it might need changing
to zero when PR23368 is fixed. That way, when PR23368 *is* fixed,
whoever's fixing it gets a failing test, they investigate, find the
comment, and update it as part of their series.
Everything else looks good.
Cheers,
Gary
next prev parent reply other threads:[~2018-10-09 13:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 10:11 Tom de Vries
2018-10-09 13:52 ` Gary Benson [this message]
2018-10-09 16:40 ` Tom de Vries
2018-10-10 9:28 ` Gary Benson
2018-10-10 13:29 ` Simon Marchi
2018-10-10 13:44 ` Gary Benson
2018-10-11 7:47 ` Tom de Vries
2018-10-11 8:33 ` Gary Benson
2018-10-13 22:18 ` Simon Marchi
2018-10-15 19:54 ` Tom de Vries
2018-10-15 22:12 ` Simon Marchi
2018-10-23 21:04 ` Simon Marchi
2018-10-23 21:05 ` Tom de Vries
2018-10-23 22:38 ` Tom de Vries
2018-10-23 23:37 ` Simon Marchi
2018-10-24 11:47 ` Tom de Vries
2018-10-24 12:09 ` [PATCH][gdb/testsuite] Log wait status on process no longer exists error Tom de Vries
2018-10-24 14:05 ` Simon Marchi
2018-12-05 19:35 ` Pedro Franco de Carvalho
2018-10-15 22:12 ` [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp Simon Marchi
2018-10-16 16:11 ` Tom de Vries
2018-10-16 17:07 ` Tom de Vries
2018-10-16 20:12 ` Simon Marchi
2018-10-17 7:30 ` Upper case test names Tom de Vries
2018-10-17 12:07 ` Simon Marchi
2018-10-18 12:56 ` Tom de Vries
2018-10-18 13:05 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009135155.GB12668@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).