Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp

[Gary Benson <gbenson@redhat.com>]

Simon Marchi wrote:
> On 2018-10-10 05:27, Gary Benson wrote:
> > Tom de Vries wrote:
> > > On 10/9/18 3:51 PM, Gary Benson wrote:
> > > > Tom de Vries wrote:
> > > > >      append FLAGS " \"$binfile\""
> > > > >      append FLAGS " -batch"
> > > > > +    append FLAGS " -ex \"target native\""
> > > > >      append FLAGS " -ex \"catch exec\""
> > > > >      append FLAGS " -ex \"set follow-exec-mode new\""
> > > >
> > > > I'm a little confused with this part, doesn't this force the
> > > > test to run on the host?
> > >
> > > The "target native" was an attempt to fix problems when running
> > > with --target_board=native-gdbserver. Perhaps it's better to
> > > bail out in that case, but I haven't yet figured out how to. Any
> > > advice here?
> >
> > Tests that can't run remote usually bail with something like this
> > at the start:
> >
> >   if ![isnative] then {
> >       return
> >   }
> 
> I have not looked at the test (I can do it latter today if
> necessary), but this comment caught my attention.  isnative is
> likely not what you want to use, make sure to read the "Local vs
> Remote vs Native" section of the gdb/testsuite/README file.

Oh!  Ok, so [target_info gdb_protocol] != ""] maybe?
Thanks Simon!

Gary