From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42404 invoked by alias); 11 Oct 2018 08:33:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42326 invoked by uid 89); 11 Oct 2018 08:33:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS,UNSUBSCRIBE_BODY autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Oct 2018 08:33:22 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 96837C070E06; Thu, 11 Oct 2018 08:33:21 +0000 (UTC) Received: from blade.nx (ovpn-117-250.ams2.redhat.com [10.36.117.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id 264531084287; Thu, 11 Oct 2018 08:33:21 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 491D58019FA9; Thu, 11 Oct 2018 09:33:20 +0100 (BST) Date: Thu, 11 Oct 2018 08:33:00 -0000 From: Gary Benson To: Tom de Vries Cc: Simon Marchi , gdb-patches@sourceware.org, Pedro Alves Subject: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp Message-ID: <20181011083318.GA13751@blade.nx> References: <20181005101122.GA23867@delia> <20181009135155.GB12668@blade.nx> <8f8ffb94-5a0c-8b2b-d541-eaacd7d1f42c@suse.de> <20181010092735.GA29557@blade.nx> <20181010134423.GA23926@blade.nx> <20181011074744.GA7677@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181011074744.GA7677@delia> X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00272.txt.bz2 Tom de Vries wrote: > On Wed, Oct 10, 2018 at 02:44:24PM +0100, Gary Benson wrote: > > Oh! Ok, so [target_info gdb_protocol] != ""] maybe? > > Attached patch uses this this. > > OK for trunk? Please reorder the checks at the start like this, to minimize the work done before bailing: 1. check gdb_protocol native 2. check /bin/ls exists on target 3. build_executable The patch is ok by me with these changes, but please wait for a maintainer to give the final approval, I don't have those powers :) And thanks for doing the work Tom! Cheers, Gary > [gdb/testsuite] Rewrite catch-follow-exec.exp > > There are two problems with the current catch-follow-exec.exp: > - INTERNAL_GDBFLAGS (containing the datadir setting) is not used > - remote host testing doesn't work > > Fix the former by using gdb_spawn_with_cmdline_opts. Fix the latter by > requiring gdb-native. > > Build on x86_64-linux with and without ubsan, tested with and without > --target_board=native-gdbserver. > > 2018-10-05 Tom de Vries > > PR gdb/23730 > * gdb.base/catch-follow-exec.c: Add copyright notice. > * gdb.base/catch-follow-exec.exp: Rewrite to use > gdb_spawn_with_cmdline_opts. Require gdb-native. > > --- > gdb/testsuite/gdb.base/catch-follow-exec.c | 17 ++++++++++++ > gdb/testsuite/gdb.base/catch-follow-exec.exp | 41 ++++++++++++++++++++++------ > 2 files changed, 49 insertions(+), 9 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/catch-follow-exec.c b/gdb/testsuite/gdb.base/catch-follow-exec.c > index fa68a2a34e..1a59f58aa5 100644 > --- a/gdb/testsuite/gdb.base/catch-follow-exec.c > +++ b/gdb/testsuite/gdb.base/catch-follow-exec.c > @@ -1,3 +1,20 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2018 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > #include > #include > #include > diff --git a/gdb/testsuite/gdb.base/catch-follow-exec.exp b/gdb/testsuite/gdb.base/catch-follow-exec.exp > index 0e32ed4a6f..2ccd0115e7 100644 > --- a/gdb/testsuite/gdb.base/catch-follow-exec.exp > +++ b/gdb/testsuite/gdb.base/catch-follow-exec.exp > @@ -22,8 +22,8 @@ if {[build_executable "failed to prepare" $testfile $srcfile debug] == -1} { > return -1 > } > > -if { ![remote_file target exists /bin/bash] } { > - unsupported "no bash" > +if { [target_info gdb_protocol] != "" } { > + unsupported "not native" > return > } > > @@ -34,7 +34,7 @@ if { ![remote_file target exists /bin/ls] } { > > proc catch_follow_exec { } { > global binfile > - global GDB > + global gdb_spawn_id > > set test "catch-follow-exec" > > @@ -45,13 +45,36 @@ proc catch_follow_exec { } { > append FLAGS " -ex \"run\"" > append FLAGS " -ex \"info prog\"" > > - catch {exec /bin/bash -c "$GDB $FLAGS"} catchlog > - send_log "$catchlog\n" > + gdb_exit > + if {[gdb_spawn_with_cmdline_opts "$FLAGS"] != 0} { > + fail "spawn" > + return > + } > + > + gdb_test_multiple "" "run til exit" { > + "runtime error:" { > + # Error in case of --enable-ubsan > + fail "No runtime error" > + } > + eof { > + set result [wait -i $gdb_spawn_id] > + verbose $result > + > + gdb_assert { [lindex $result 2] == 0 } > + > + # We suspect this will be zero instead of one after fixing PR23368 > + # - "gdb goes to into background when hitting exec catchpoint with > + # follow-exec-mode new" > + gdb_assert { [lindex $result 3] == 1 } > + > + # Error in case of --disable-ubsan, we get > + # "CHILDKILLED SIGSEGV {segmentation violation}" as extra > + # argument(s). > + gdb_assert { [llength $result] == 4 } > + } > > - if { [regexp {No selected thread} $catchlog] } { > - pass $test > - } else { > - fail $test > + remote_close host > + clear_gdb_spawn_id > } > } > >