From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59573 invoked by alias); 11 Oct 2018 14:49:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59308 invoked by uid 89); 11 Oct 2018 14:49:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.2 required=5.0 tests=BAYES_50,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:h8300-tdep.c, gdbarchc, nds32-tdep.c, UD:amd64-windows-tdep.c X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50071.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.71) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Oct 2018 14:49:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uZu0fiwIJkEyhCqb5/9SvapBQf29PSPWKbzovFtvVq0=; b=GV6D/HGCKcfwyybbC1mOPKsQQd4OzLgXvwJ8bmdIEtxi4kC9j92/mgzF5EXJiiq7uSdGZ6mo5UKDz091kFjJ1zq3rxG9j+NWMwT/iVElmWIUuTT51tA2LmPYEOuV8biU8NUcoXel7mIzfx/lDL0T2wiGC/3BWSOZSuR6narTMLU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Received: from C02TF0U7HF1T.manchester.arm.com (217.140.106.32) by DB6PR0802MB2133.eurprd08.prod.outlook.com (2603:10a6:4:83::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.24; Thu, 11 Oct 2018 14:49:09 +0000 From: Alan Hayward To: gdb-patches@sourceware.org Cc: nd@arm.com, Alan Hayward Subject: [PATCH v3 0/3] Aarch64: Fix segfault when casting dummy calls Date: Thu, 11 Oct 2018 14:49:00 -0000 Message-Id: <20181011144905.66908-1-alan.hayward@arm.com> MIME-Version: 1.0 Content-Type: text/plain Return-Path: alan.hayward@arm.com Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00276.txt.bz2 Aarch64: Fix segfault when casting dummy calls Following Pedro's review I've squashed the new int param into a new enum and rewritten the test. Prevent the int cast in the following causing a segfault on aarch64: (gdb) b foo if (int)strcmp(name,"abc") == 0 (gdb) run The fix is to remove a bunch of code from aarch64_push_dummy_call, instead passing down the information from the caller. Patch 1 removes two ints from call_function_by_hand_dummy, replacing them with an enum. Patch 2 passes that enum down to _push_dummy_call. Patch 3 makes use of the enum in aarch64_push_dummy_call and adds a test case. Tested with make check on aarch64 and build with all targets on x86. Patch 2 needs a careful scan to make sure it doesn't break any other targets. Alan Hayward (3): Use enum for return method for dummy calls Pass return_method to _push_dummy_call Aarch64: Fix segfault when casting dummy calls gdb/aarch64-tdep.c | 35 +---- gdb/alpha-tdep.c | 7 +- gdb/amd64-tdep.c | 13 +- gdb/amd64-windows-tdep.c | 12 +- gdb/arc-tdep.c | 5 +- gdb/arm-tdep.c | 5 +- gdb/avr-tdep.c | 5 +- gdb/bfin-tdep.c | 4 +- gdb/cris-tdep.c | 9 +- gdb/csky-tdep.c | 5 +- gdb/frv-tdep.c | 5 +- gdb/gdbarch.c | 4 +- gdb/gdbarch.h | 21 ++- gdb/gdbarch.sh | 19 ++- gdb/h8300-tdep.c | 5 +- gdb/hppa-tdep.c | 10 +- gdb/i386-darwin-tdep.c | 5 +- gdb/i386-tdep.c | 5 +- gdb/ia64-tdep.c | 11 +- gdb/infcall.c | 28 ++-- gdb/iq2000-tdep.c | 8 +- gdb/lm32-tdep.c | 5 +- gdb/m32c-tdep.c | 5 +- gdb/m32r-tdep.c | 5 +- gdb/m68hc11-tdep.c | 9 +- gdb/m68k-tdep.c | 5 +- gdb/mep-tdep.c | 4 +- gdb/mips-tdep.c | 19 +-- gdb/mn10300-tdep.c | 6 +- gdb/msp430-tdep.c | 5 +- gdb/nds32-tdep.c | 5 +- gdb/nios2-tdep.c | 5 +- gdb/or1k-tdep.c | 5 +- gdb/ppc-sysv-tdep.c | 10 +- gdb/ppc-tdep.h | 25 ++-- gdb/riscv-tdep.c | 8 +- gdb/rl78-tdep.c | 5 +- gdb/rs6000-aix-tdep.c | 5 +- gdb/rs6000-lynx178-tdep.c | 5 +- gdb/rx-tdep.c | 8 +- gdb/s390-tdep.c | 7 +- gdb/score-tdep.c | 5 +- gdb/sh-tdep.c | 9 +- gdb/sparc-tdep.c | 15 +- gdb/sparc64-tdep.c | 14 +- gdb/spu-tdep.c | 5 +- gdb/testsuite/gdb.base/condbreak-solib-lib.cc | 22 +++ .../gdb.base/condbreak-solib-main.cc | 39 +++++ gdb/testsuite/gdb.base/condbreak-solib.exp | 136 ++++++++++++++++++ gdb/tic6x-tdep.c | 5 +- gdb/tilegx-tdep.c | 4 +- gdb/v850-tdep.c | 4 +- gdb/vax-tdep.c | 5 +- gdb/xstormy16-tdep.c | 5 +- gdb/xtensa-tdep.c | 10 +- 55 files changed, 444 insertions(+), 206 deletions(-) create mode 100644 gdb/testsuite/gdb.base/condbreak-solib-lib.cc create mode 100644 gdb/testsuite/gdb.base/condbreak-solib-main.cc create mode 100644 gdb/testsuite/gdb.base/condbreak-solib.exp -- 2.17.1 (Apple Git-112)