[PATCH] Clear static_links in reread_symbols

[PATCH] Clear static_links in reread_symbols

[Tom Tromey]

-fsanitize=address pointed out a use-after free in
objfile_register_static_link.  The bug turned out to be that
reread_symbols does not clear the static_links field; this leaves a
hash table that is filled with freed pointers.

Jan's (now quite old) idea of replacing reread_symbols with a simple
delete/new still seems good to me, and it's worth noting that it would
have avoided this bug.

Tested by the buildbot and by observing the change with
-fsanitize=address.

gdb/ChangeLog
2018-10-18  Tom Tromey  <tom@tromey.com>

	* symfile.c (reread_symbols): Clear "static_links".
---
 gdb/ChangeLog | 4 ++++
 gdb/symfile.c | 1 +
 2 files changed, 5 insertions(+)

diff --git a/gdb/symfile.c b/gdb/symfile.c
index 6a1140edbc..8ab6a25de7 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -2497,6 +2497,7 @@ reread_symbols (void)
 	  objfile->psymtabs_addrmap = NULL;
 	  objfile->free_psymtabs = NULL;
 	  objfile->template_symbols = NULL;
+	  objfile->static_links = NULL;
 
 	  /* obstack_init also initializes the obstack so it is
 	     empty.  We could use obstack_specify_allocation but
-- 
2.17.1

Re: [PATCH] Clear static_links in reread_symbols

[Kevin Buettner]

On Thu, 18 Oct 2018 16:05:22 -0600
Tom Tromey <tom@tromey.com> wrote:

> Tested by the buildbot and by observing the change with
> -fsanitize=address.
> 
> gdb/ChangeLog
> 2018-10-18  Tom Tromey  <tom@tromey.com>
> 
> 	* symfile.c (reread_symbols): Clear "static_links".

Okay.

Kevin