Re: [PATCH 1/2] RISC-V: Print FP regs as union of float types.

[Kevin Buettner <kevinb@redhat.com>]

On Fri, 19 Oct 2018 14:49:07 -0700
Jim Wilson <jimw@sifive.com> wrote:

> A 64-bit FP register can hold either a single or double float value, so
> print it as both types by using a union type for FP registers.  Likewise
> for 128-bit regs which can also hold long double.
> 
> 	gdb/
> 	* riscv-tdep.c (riscv_fpreg_d_type, riscv_fpreg_q_type): New.
> 	(riscv_register_type): Use them.
> 	(riscv_print_one_register_info): Handle union of floats same as float.
> 	* riscv-tdep.h (struct gdbarch_tdep): Add riscv_fpreg_d_type and
> 	riscv_fpreg_q_type fields.

This is okay, except for the following nits...

> +static struct type *
> +riscv_fpreg_d_type (struct gdbarch *gdbarch)
> +{
> +  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
> +
> +  if (!tdep->riscv_fpreg_d_type)

The GDB coding standard say that this must be coded as:

     if (tdep->riscv_fpreg_d_type == NULL)

Though I think we prefer nullptr over NULL these days.

(I realize that there's code in GDB which does not conform to this
standard.)

Likewise, here:

> +static struct type *
> +riscv_fpreg_q_type (struct gdbarch *gdbarch)
> +{
> +  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
> +
> +  if (!tdep->riscv_fpreg_q_type)

Kevin