From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Marius Muench <munch@eurecom.fr>
Subject: Re: [PATCH] ARM: Do not use FP reg when on AAPCS
Date: Tue, 23 Oct 2018 17:16:00 -0000 [thread overview]
Message-ID: <20181023101649.23d4af8b@pinnacle.lan> (raw)
In-Reply-To: <b2ceb6fd-5df8-4d91-d2e9-1aea26047480@eurecom.fr>
On Tue, 23 Oct 2018 15:03:39 +0200
Marius Muench <munch@eurecom.fr> wrote:
> Hi all,
>
> GDB tries to dereference the frame pointer in arm_scan_prologue as a
> last resort to create frame information.
> However, the more recent AAPCS ABI does not make use of a frame pointer.
>
> This patch checks whether the specified arm_abi is AAPCS before
> dereferencing the "frame pointer". If so, just return as efforts to use
> it for restoring frame information won't work.
>
> Cheers,
> Marius
>
> gdb/ChangeLog
> 2018-10-23 Marius Muench <marius.muench@eurecom.fr>
>
> * arm-tdeb.c (arm_scan_prologue): Don't dereference FP reg
> when on aapcs.
Typo on filename above. (s/tdeb/tdep/) While you're changing it,
please capitalize AAPCS too.
Otherwise, okay.
Kevin
next prev parent reply other threads:[~2018-10-23 17:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 13:03 Marius Muench
2018-10-23 17:16 ` Kevin Buettner [this message]
2018-10-24 11:40 ` Marius Muench
2018-10-24 16:47 ` Kevin Buettner
2018-10-24 17:23 ` Pedro Alves
2018-10-24 19:37 ` Marius Muench
2018-10-25 20:34 ` Kevin Buettner
2018-10-26 12:13 ` Marius Muench
2018-11-06 17:53 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023101649.23d4af8b@pinnacle.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=munch@eurecom.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).