From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69777 invoked by alias); 23 Oct 2018 17:16:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69767 invoked by uid 89); 23 Oct 2018 17:16:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Oct 2018 17:16:52 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C8E83002617; Tue, 23 Oct 2018 17:16:51 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08A8D66FF9; Tue, 23 Oct 2018 17:16:50 +0000 (UTC) Date: Tue, 23 Oct 2018 17:16:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Marius Muench Subject: Re: [PATCH] ARM: Do not use FP reg when on AAPCS Message-ID: <20181023101649.23d4af8b@pinnacle.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00515.txt.bz2 On Tue, 23 Oct 2018 15:03:39 +0200 Marius Muench wrote: > Hi all, > > GDB tries to dereference the frame pointer in arm_scan_prologue as a > last resort to create frame information. > However, the more recent AAPCS ABI does not make use of a frame pointer. > > This patch checks whether the specified arm_abi is AAPCS before > dereferencing the "frame pointer". If so, just return as efforts to use > it for restoring frame information won't work. > > Cheers, > Marius > > gdb/ChangeLog > 2018-10-23 Marius Muench > > * arm-tdeb.c (arm_scan_prologue): Don't dereference FP reg > when on aapcs. Typo on filename above. (s/tdeb/tdep/) While you're changing it, please capitalize AAPCS too. Otherwise, okay. Kevin