From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91417 invoked by alias); 24 Oct 2018 18:04:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91395 invoked by uid 89); 24 Oct 2018 18:04:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:942, symbol_language, sangamesh, H*i:sk:OF9F719 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Oct 2018 18:04:36 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9OHxaCi048539 for ; Wed, 24 Oct 2018 14:04:34 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2natbmk40j-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 24 Oct 2018 14:04:34 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Oct 2018 19:04:31 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 24 Oct 2018 19:04:30 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w9OI4OLA37421096 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 24 Oct 2018 18:04:24 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 748E9AE053; Wed, 24 Oct 2018 18:04:24 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 634B5AE045; Wed, 24 Oct 2018 18:04:24 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.152.213.211]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 24 Oct 2018 18:04:24 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 31F38D801EB; Wed, 24 Oct 2018 20:04:24 +0200 (CEST) Subject: Re: [PATCH] SYMBOL_LANGUAGE assertion failure on AIX To: sangamesh.swamy@in.ibm.com (Sangamesh Mallayya) Date: Wed, 24 Oct 2018 18:04:00 -0000 From: "Ulrich Weigand" Cc: keiths@redhat.com (Keith Seitz), gdb-patches@sourceware.org In-Reply-To: from "Sangamesh Mallayya" at Oct 23, 2018 12:09:33 PM MIME-Version: 1.0 x-cbid: 18102418-0028-0000-0000-0000030C9A53 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18102418-0029-0000-0000-000023C8A9A5 Message-Id: <20181024180424.31F38D801EB@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-10/txt/msg00557.txt.bz2 Sangamesh Mallaya wrote: > Thanks for the review and comments. > Attaching the changelog file and git formatted patch. > * xcoffread.c (read_xcoff_symtab): Fix SYMBOL_LANGUAGE assertion > failure. GNU coding style is to mention in the ChangeLog *what* was changed, not why the change is done. "Fix assertion failure" doesn't describe *what* actually was changed, so it should read more like this: * xcoffread.c (read_xcoff_symtab): Pass deduced language to symtab_start instead of always using language_unknown. (You can and should still describe the reason for the change, e.g. that it fixes an assertion failure, in the git commit message.) You should have git commit access yourself now, right? Feel free to commit the change now. (If you don't have access, please let me know.) Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com