From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Jim Wilson <jimw@sifive.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] RISC-V: Linux signal frame support.
Date: Fri, 26 Oct 2018 07:32:00 -0000 [thread overview]
Message-ID: <20181026073205.GQ2929@embecosm.com> (raw)
In-Reply-To: <CAFyWVaYFSWGfC_idDngHGd6fMKO8n2hohzdXWXcBh0MoqCqfTA@mail.gmail.com>
* Jim Wilson <jimw@sifive.com> [2018-10-25 16:58:51 -0700]:
> This adds initial support for unwinding through signal trampolines.
> I've tested it by hand and can see correct register values for the
> frame where the signal occurred. I've tested it with the gdb
> testsuite on an unleashed board with fc29 and a patched kernel, and I
> get 37 more passes and 35 fewer failures.
>
> The result isn't as good as I hoped, as I'm getting a lot of failures
> from the fact that stepi into handler doesn't work, but that
> apparently is not expected to work with software single step which is
> all I have implemented so far.
>
> This also fixes some duplicate comments the way that Simon Marchi
> suggested back in August, by moving them to a .h file and modifying
> the .c file to refer to the comments in the .h file.
This series looks good to me.
Thanks,
Andrew
prev parent reply other threads:[~2018-10-26 7:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 23:59 Jim Wilson
2018-10-25 23:59 ` [PATCH 1/2] " Jim Wilson
2018-10-26 3:25 ` Kevin Buettner
2018-10-26 17:34 ` Jim Wilson
2018-10-26 0:01 ` [PATCH 2/2] " Jim Wilson
2018-10-26 3:58 ` Kevin Buettner
2018-10-26 16:26 ` John Baldwin
2018-10-26 7:32 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026073205.GQ2929@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jimw@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).