From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: sangamesh.swamy@in.ibm.com (Sangamesh Mallayya)
Cc: gdb-patches@sourceware.org, kevinb@redhat.com (Kevin Buettner)
Subject: Re: [PATCH] Adding support for reding signal handler frame in AIX
Date: Wed, 31 Oct 2018 10:37:00 -0000 [thread overview]
Message-ID: <20181031103743.D2C24D801B6@oc3748833570.ibm.com> (raw)
In-Reply-To: <OFBB7F5B7D.BE894658-ON65258337.0036C171-65258337.00389F38@notes.na.collabserv.com> from "Sangamesh Mallayya" at Oct 31, 2018 10:18:31 AM
Sangamesh Mallayya wrote:
> Attaching the modified files.
> Please review and let me know if fine to commit.
This is OK to commit.
> 2018-10-31 Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
>
> * rs6000-aix-tdep.c: New signal handler frame_unwinder structure.
> (aix_sighandle_frame_cache): New Function.
> (aix_sighandle_frame_this_id): New Function.
> (aix_sighandle_frame_prev_register): New Function.
> (aix_sighandle_frame_sniffer): New Function.
>
> 2018-10-31 Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
>
> * gdb.arch/aix-sighandle.c: New file.
> * gdb.arch/aix-sighandle.exp: New file.
When committing, please add a few more details to the ChangeLog,
in particular:
- the added #include statements
- the new #defines
- the new variable aix_sighandle_frame_unwind
- the added call to frame_unwind_append_unwinder
The ChangeLog for rs6000-aix-tdep should read something like this:
* rs6000-aix-tdep.c: Include "trad-frame.h" and "frame-unwind.h".
(SIG_FRAME_LR_OFFSET64): New define.
(SIG_FRAME_FP_OFFSET64): New define.
(aix_sighandle_frame_cache): New function.
(aix_sighandle_frame_this_id): New function.
(aix_sighandle_frame_prev_register): New function.
(aix_sighandle_frame_sniffer): New function.
(aix_sighandle_frame_unwind): New global variable.
(rs6000_aix_init_osabi): Install new frame unwinder.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2018-10-31 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 5:54 Sangamesh Mallayya
2018-09-04 23:18 ` Kevin Buettner
2018-09-10 6:32 ` Sangamesh Mallayya
2018-09-10 17:34 ` Kevin Buettner
2018-09-12 13:53 ` Ulrich Weigand
2018-09-27 8:33 ` Sangamesh Mallayya
[not found] ` <OF4C5ED06A.3C846B3C-ON65258315.002EABF7-65258315.002F01D3@LocalDomain>
2018-10-30 7:16 ` Sangamesh Mallayya
2018-10-30 10:20 ` Ulrich Weigand
2018-10-31 10:18 ` Sangamesh Mallayya
2018-10-31 10:37 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031103743.D2C24D801B6@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=sangamesh.swamy@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).