From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17285 invoked by alias); 31 Oct 2018 10:37:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17272 invoked by uid 89); 31 Oct 2018 10:37:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=H*x:version, sk:aix_sig, H*x:2.5, H*UA:2.5 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Oct 2018 10:37:50 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9VAYAaD111734 for ; Wed, 31 Oct 2018 06:37:49 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2nf9rhtrrv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 31 Oct 2018 06:37:48 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 31 Oct 2018 10:37:47 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 31 Oct 2018 10:37:46 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w9VAbigE52887662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 31 Oct 2018 10:37:44 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 15AAA4204D; Wed, 31 Oct 2018 10:37:44 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E19D4204C; Wed, 31 Oct 2018 10:37:44 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.152.213.211]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 31 Oct 2018 10:37:44 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id D2C24D801B6; Wed, 31 Oct 2018 11:37:43 +0100 (CET) Subject: Re: [PATCH] Adding support for reding signal handler frame in AIX To: sangamesh.swamy@in.ibm.com (Sangamesh Mallayya) Date: Wed, 31 Oct 2018 10:37:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, kevinb@redhat.com (Kevin Buettner) In-Reply-To: from "Sangamesh Mallayya" at Oct 31, 2018 10:18:31 AM MIME-Version: 1.0 x-cbid: 18103110-0020-0000-0000-000002DD7267 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18103110-0021-0000-0000-0000212CC6DC Message-Id: <20181031103743.D2C24D801B6@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-10/txt/msg00740.txt.bz2 Sangamesh Mallayya wrote: > Attaching the modified files. > Please review and let me know if fine to commit. This is OK to commit. > 2018-10-31 Sangamesh Mallayya > > * rs6000-aix-tdep.c: New signal handler frame_unwinder structure. > (aix_sighandle_frame_cache): New Function. > (aix_sighandle_frame_this_id): New Function. > (aix_sighandle_frame_prev_register): New Function. > (aix_sighandle_frame_sniffer): New Function. > > 2018-10-31 Sangamesh Mallayya > > * gdb.arch/aix-sighandle.c: New file. > * gdb.arch/aix-sighandle.exp: New file. When committing, please add a few more details to the ChangeLog, in particular: - the added #include statements - the new #defines - the new variable aix_sighandle_frame_unwind - the added call to frame_unwind_append_unwinder The ChangeLog for rs6000-aix-tdep should read something like this: * rs6000-aix-tdep.c: Include "trad-frame.h" and "frame-unwind.h". (SIG_FRAME_LR_OFFSET64): New define. (SIG_FRAME_FP_OFFSET64): New define. (aix_sighandle_frame_cache): New function. (aix_sighandle_frame_this_id): New function. (aix_sighandle_frame_prev_register): New function. (aix_sighandle_frame_sniffer): New function. (aix_sighandle_frame_unwind): New global variable. (rs6000_aix_init_osabi): Install new frame unwinder. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com